Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gate SkipReadOnlyValidationGCE to Deprecated #121083

Conversation

thockin
Copy link
Member

@thockin thockin commented Oct 9, 2023

This was created as alpha (off by default) but should probably have used the "Deprecated" setting. Changing it now makes it on by default and still disable-able.

There was no KEP for this - it was considered a "cleanup" which we were being somewhat paranoid about.

Previous versions of Kubernetes on Google Cloud required that workloads (e.g. Deployments, DaemonSets, etc.) which used PersistentDisk volumes were using them in read-only mode.  This validation provided very little value at relatively host implementation cost, and will no longer be validated.  If this is a problem for a specific use-case, please set the `SkipReadOnlyValidationGCE` gate to false to re-enable the validation, and file a kubernetes bug with details. 

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 9, 2023
@thockin
Copy link
Member Author

thockin commented Oct 9, 2023

@kubernetes/release-managers since this did not have a KEP, but does have a gate (bad!!), I can push this to the next release if you prefer. It seems low risk, but those are "famous last words".

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@xmudrii
Copy link
Member

xmudrii commented Oct 9, 2023

@thockin @kubernetes/release-team and @kubernetes/release-team-leads will be of a better help here. :)

@thockin
Copy link
Member Author

thockin commented Oct 9, 2023

woops! I let the auto-complete win.

@thockin
Copy link
Member Author

thockin commented Oct 14, 2023

I need an opinion from @kubernetes/release-team and/or @kubernetes/release-team-leads

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

/kind cleanup
/sig apps

ref #114436

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2023
@Priyankasaggu11929
Copy link
Member

I need an opinion from https://github.com/orgs/kubernetes/teams/release-team and/or https://github.com/orgs/kubernetes/teams/release-team-leads

Hello @thockin, I've started a slack thread in #sig-release for the discussion.

@dims
Copy link
Member

dims commented Oct 16, 2023

/approve
/lgtm
/hold

/cc @liggitt

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35c9f9388236dfe660a6e3cee96514844ed083da

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Priyankasaggu11929
Copy link
Member

Hello @thockin, I've started a slack thread in #sig-release for the discussion.

Per the above discussion, LGTM from 1.29 Release Team too. Thank you!

This was created as alpha (off by default) but should probably have used
the "Deprecated" setting.  Changing it now makes it on by default and
still disable-able.
@thockin thockin force-pushed the gate_bump_remove_gce_readonly_pd_validation branch from 5f347cf to d6d2c57 Compare October 16, 2023 19:38
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@thockin
Copy link
Member Author

thockin commented Oct 16, 2023

Comments updated.

@liggitt
Copy link
Member

liggitt commented Oct 16, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a05f081d67821a7d3fef699e94bb3eb9dab7df29

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 62643ca into kubernetes:master Oct 17, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 17, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

Have we updated k8s website for this change?

@pacoxu
Copy link
Member

pacoxu commented Oct 19, 2023

I open kubernetes/website#43574 to sync the status.

@sftim
Copy link
Contributor

sftim commented Jan 2, 2024

Deprecated doesn't sound right to me. We want the feature gate to end up as on by default and locked to true, and we call that “stable” not deprecated.

@thockin thockin deleted the gate_bump_remove_gce_readonly_pd_validation branch March 10, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants