New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set gate SkipReadOnlyValidationGCE to Deprecated #121083
Set gate SkipReadOnlyValidationGCE to Deprecated #121083
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kubernetes/release-managers since this did not have a KEP, but does have a gate (bad!!), I can push this to the next release if you prefer. It seems low risk, but those are "famous last words". |
@thockin @kubernetes/release-team and @kubernetes/release-team-leads will be of a better help here. :) |
woops! I let the auto-complete win. |
I need an opinion from @kubernetes/release-team and/or @kubernetes/release-team-leads |
/kind cleanup ref #114436
|
Hello @thockin, I've started a slack thread in #sig-release for the discussion. |
/approve /cc @liggitt |
LGTM label has been added. Git tree hash: 35c9f9388236dfe660a6e3cee96514844ed083da
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Per the above discussion, LGTM from 1.29 Release Team too. Thank you! |
This was created as alpha (off by default) but should probably have used the "Deprecated" setting. Changing it now makes it on by default and still disable-able.
5f347cf
to
d6d2c57
Compare
Comments updated. |
/lgtm |
LGTM label has been added. Git tree hash: a05f081d67821a7d3fef699e94bb3eb9dab7df29
|
Have we updated k8s website for this change? |
I open kubernetes/website#43574 to sync the status. |
Deprecated doesn't sound right to me. We want the feature gate to end up as on by default and locked to true, and we call that “stable” not deprecated. |
This was created as alpha (off by default) but should probably have used the "Deprecated" setting. Changing it now makes it on by default and still disable-able.
There was no KEP for this - it was considered a "cleanup" which we were being somewhat paranoid about.