Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] [go] Bump images, dependencies and versions to go 1.20.10 #121150

Merged
merged 1 commit into from Oct 12, 2023
Merged

[release-1.25] [go] Bump images, dependencies and versions to go 1.20.10 #121150

merged 1 commit into from Oct 12, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 11, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Bump images, dependencies and versions to go 1.20.10

Which issue(s) this PR fixes:

xref kubernetes/release#3311

Does this PR introduce a user-facing change?

Kubernetes is now built with Go 1.20.10

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @saschagrunert @xmudrii @jeremyrickard @Verolop @liggitt @dims
cc @kubernetes/release-engineering

@cpanato
[go] Bump images, dependencies and versions to go 1.20.10
b37b9a8 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/test sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2023
@liggitt
Copy link
Member

liggitt commented Oct 11, 2023

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/98 nodes are available: 10 Insufficient memory, 98 Insufficient cpu. preemption: 0/98 nodes are available: 98 No preemption victims found for incoming pod..)

hmm

@liggitt
Copy link
Member

liggitt commented Oct 11, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
xmudrii
xmudrii approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a23ffd8805129c5009242417f415192767157a4f

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@cpanato cpanato mentioned this pull request Oct 11, 2023
Closed
28 tasks
@xmudrii
Copy link
Member

xmudrii commented Oct 11, 2023

/retest

1 similar comment
@saschagrunert
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 12, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 12, 2023 •
edited

looks like something is wrong with the pull-kubernetes-node-e2e-containerd tests it is happening in all release branches, has anything changed for that?

or maybe that is because the go update? 🤔

Looking for address 'bootstrap-e2e-master-ip'
ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
 - The resource 'projects/k8s-infra-e2e-boskos-040/regions/us-west1/addresses/bootstrap-e2e-master-ip' was not found

@liggitt @saschagrunert

@saschagrunert
Copy link
Member

/retest

@cpanato cpanato mentioned this pull request Oct 12, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 3e70c03 into kubernetes:release-1.25 Oct 12, 2023
18 checks passed
@cpanato cpanato deleted the update-go-rel125 branch October 12, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@xmudrii xmudrii xmudrii approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@liggitt liggitt

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @k8s-ci-robot @liggitt @xmudrii @saschagrunert