Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GA featuregate about ProbeTerminationGracePeriod in 1.29 #121257

Merged
merged 1 commit into from Oct 17, 2023
Merged

Remove GA featuregate about ProbeTerminationGracePeriod in 1.29 #121257

merged 1 commit into from Oct 17, 2023

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Oct 16, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove GA featuregate about ProbeTerminationGracePeriod in 1.29

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @bzsuni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 16, 2023
swatisehgal
swatisehgal reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea8ae65521285f01e55488c13a7a92a0e5607be8

@swatisehgal
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 16, 2023
@swatisehgal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2023
@bzsuni
Remove GA featuregate about ProbeTerminationGracePeriod in 1.29
27abf99 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the ga/ProbeTerminationGracePeriod branch from e135d19 to 27abf99 Compare October 16, 2023 12:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 16, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 16, 2023 •
edited

Does e2e need it?
Could you please ok-to-test for this pr? Thank you very much @swatisehgal

@swatisehgal
Copy link
Contributor

swatisehgal commented Oct 16, 2023 •
edited

/ok-to-test

Does e2e need it?

I would expect e2e tests to be written with the assumption that the feature gate is locked to ON by default so don't expect any changes to e2e but we should make sure that all the tests pass. If there are jobs specifically for this feature we should enable them here.

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 16, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2023
@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 16, 2023

/test pull-kubernetes-e2e-kind

@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 16, 2023

/test pull-kubernetes-unit

@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 16, 2023

@swatisehgal Could you please re-review this PR? The CI has passed，thank you very much

@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 16, 2023

/assign @liggitt
Could you please review this pr?
And this is the issue for my membership application: kubernetes/org#4509
Would you be willing to sponsor or support my membership request? Thanks.

swatisehgal
swatisehgal approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9c77e9982cdb2807d315fec497ecbce75a866e0c

@swatisehgal
Copy link
Contributor

/assign @dims
for features approval

@dims
Copy link
Member

dims commented Oct 17, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@pacoxu
Copy link
Member

pacoxu commented Oct 17, 2023

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit bbcbfe4 into kubernetes:master Oct 17, 2023
16 checks passed
SIG Node CI/Test Board automation moved this from Triage to Done Oct 17, 2023
SIG Node PR Triage automation moved this from Triage to Done Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@liggitt liggitt

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bzsuni @k8s-ci-robot @swatisehgal @dims @pacoxu @liggitt