[KEP - 3085] Add e2e test for PodReadyToStartContainerCondition when config map is created #121321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
charles-chenzz
commented
Oct 18, 2023
|
/test |
|
@kannon92: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
@charles-chenzz I think we should revert the previous PR. I don't think this test actually does what we want. I am also not exactly sure if we can do this after all. The test case I was thinking of:
I don't think you are able to add volumes to a pod after it has been running. I think you want to look into how to create a secret/config-map in the node_e2e tests. |
can you point out in which files? I think we should wait the CI hints and gain more infos then decide if we need to revert the previous PR. wdyt? @kannon92 |
I can't actually find a test in node_e2e that creates a secret or config-map. So I am thinking that this test may be tricky than we thought. I opened up a revert just in case |
k8s-ci-robot
added
the
needs-rebase
|
/retitle WIP: Investigate flaky test for PodReadyToStartContainerCondition |
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
error was due to my mistake of removing wrong code 😓 fixing later today |
charles-chenzz
force-pushed
the
fix_flaky_PodReadyToStartContainersCondition
branch
from
c8fc878
to
fd34173
Compare
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
error unrelated now |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2c77f0e1af678befdf97229e804e9ca518b1b348
|
charles-chenzz
force-pushed
the
fix_flaky_PodReadyToStartContainersCondition
branch
from
fd34173
to
367bbd0
Compare
k8s-ci-robot
removed
the
lgtm
|
/test pull-kubernetes-node-kubelet-serial-containerd |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8470931885bfb33ae8ada92036c61140507ea949
|
kannon92
moved this from PRs Waiting on Author
to PRs - Needs Approver
in SIG Node CI/Test Board
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charles-chenzz, pacoxu, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Nice work on leading this @charles-chenzz! |
charles-chenzz
deleted the
fix_flaky_PodReadyToStartContainersCondition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
add e2e test for podreadytostartcontainercondition, as this is part of KEP 3085
Which issue(s) this PR fixes:
Fixes #121317
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: