Fix flaky test for services that shouldn't be available when PublishNotReadyAddresses is false

[vlasebian]

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fixes a flaky network e2e test that checks the ability to connect to terminating and unready endpoints if PublishNotReadyAddresses is false. The fix, as described in the issue, checks if the rules are programmed on both the nodes that are used in the test, not only on one.

Which issue(s) this PR fixes:

Fixes #121209

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @vlasebian!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @vlasebian. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aojea]

/ok-to-test

[aojea]

replace Part of #121209 by Fixes #121209 , so the bot autoclose the referred issue once this PR merges

[vlasebian]

Replaced!

[vlasebian]

/test pull-kubernetes-linter-hints

[k8s-ci-robot]

@vlasebian: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-e2e-gci-gce-ipvs	feb0e2f	link	false	/test pull-kubernetes-e2e-gci-gce-ipvs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vlasebian]

Hi, @aojea! I checked the failing job, but I am a bit stuck. From what I see in the job details, the pause-pod-1 was not created because of a reserved name error:

Oct 29 17:00:48.327: INFO: At 2023-10-29 16:59:48 +0000 UTC - event for pause-pod-1: {kubelet bootstrap-e2e-minion-group-fmmh} FailedCreatePodSandBox: Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = context deadline exceeded
Oct 29 17:00:48.327: INFO: At 2023-10-29 17:00:02 +0000 UTC - event for pause-pod-1: {kubelet bootstrap-e2e-minion-group-fmmh} FailedCreatePodSandBox: Failed to create pod sandbox: rpc error: code = Unknown desc = failed to reserve sandbox name "pause-pod-1_services-2520_aff7233e-4dde-4b0c-a5c9-bfa8b8b53e81_0": name "pause-pod-1_services-2520_aff7233e-4dde-4b0c-a5c9-bfa8b8b53e81_0" is reserved for "031d24d9d540906527d873921245e19c6e9730a8edc816465c59fbd079f0b7ae"

Is there something wrong in the PR? Is there some kind of clean up that needs to be done so that name is available for the pod? Or is it okay to just retrigger the job?

[aojea]

Is there something wrong in the PR? Is there some kind of clean up that needs to be done so that name is available for the pod? Or is it okay to just retrigger the job?

the other jobs are passing and this job has a lot of failures that are related to creating pods

Oct 29 17:00:54.986: INFO: At 2023-10-29 16:55:56 +0000 UTC - event for pod1: {kubelet bootstrap-e2e-minion-group-fmmh} FailedMount: MountVolume.SetUp failed for volume "kube-api-access-qwsxf" : failed to sync configmap cache: timed out waiting for the condition

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 84b5d9ffdfba72304440710bb8eb78ed87bbd26c

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, vlasebian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/network/OWNERS [aojea]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment