Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver: set APF featuregate to stable #121638

Merged
merged 1 commit into from Oct 31, 2023
Merged

apiserver: set APF featuregate to stable #121638

merged 1 commit into from Oct 31, 2023

Conversation

tkashem
Copy link
Contributor

@tkashem tkashem commented Oct 31, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Priority and Fairness feature is stable in 1.29, the feature gate will be removed in 1.31

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/1040-priority-and-fairness

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 31, 2023
@tkashem
Copy link
Contributor Author

tkashem commented Oct 31, 2023

/cc @MikeSpreitzer @wojtek-t
/assign @liggitt

@tkashem tkashem changed the title apiserver: set APF featuregate to ga apiserver: set APF featuregate to stable Oct 31, 2023
@liggitt
Copy link
Member

liggitt commented Oct 31, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55c4c0ac8ebc281fa04ac3fafac08fbf1815e20c

@liggitt liggitt added this to the v1.29 milestone Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@tkashem tkashem mentioned this pull request Oct 31, 2023
Open
@wojtek-t
Copy link
Member

/lgtm

Thanks!

@tkashem
Copy link
Contributor Author

tkashem commented Oct 31, 2023

I see a data race, opened: #121643

/test pull-kubernetes-unit

@tkashem
Copy link
Contributor Author

tkashem commented Oct 31, 2023

I also see a flake, does not seem related to this PR:

{Failed;  === RUN   TestStoreDeleteCollectionWithContextCancellation

Err: connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:37421: connect: connection refused"

@liggitt
Copy link
Member

liggitt commented Oct 31, 2023

unit flake is #121627

@k8s-ci-robot k8s-ci-robot merged commit 74fefd8 into kubernetes:master Oct 31, 2023
15 of 16 checks passed
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2023
@npolshakova npolshakova mentioned this pull request Nov 1, 2023
Closed
4 tasks
@tkashem tkashem deleted the apf-ga branch November 6, 2023 16:32
@tkashem tkashem mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer Awaiting requested review from MikeSpreitzer

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@dims dims Awaiting requested review from dims

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@liggitt liggitt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tkashem @liggitt @k8s-ci-robot @wojtek-t @leilajal