test/e2e_kubeadm: add test for the kubeadm:cluster-admins CRB #121674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
triage/accepted
neolit123
commented
Nov 1, 2023
There was a problem hiding this comment.
tested locally:
# create a kubeadm cluster with artifacts from latest HEAD
# ...
# build the e2e suite
make WHAT=test/e2e_kubeadm/e2e_kubeadm.test
# run the suite
sudo ./_output/local/go/bin/e2e_kubeadm.test --kubeconfig /etc/kubernetes/admin.conf --ginkgo.focus=admin --ginkgo.v
Nov 1 16:33:01.830: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
Running Suite: E2EKubeadm suite - /home/lubo/go/src/k8s.io/kubernetes
=====================================================================
Random Seed: 1698849181 - will randomize all specs
Will run 1 of 38 specs
SSSSSSSSSSSSS
------------------------------
[sig-cluster-lifecycle] [area-kubeadm] admin CRB must exist and be bound to the cluster-admin ClusterRole
test/e2e_kubeadm/admin_test.go:49
STEP: Creating a kubernetes client @ 11/01/23 16:33:01.838
Nov 1 16:33:01.838: INFO: >>> kubeConfig: /etc/kubernetes/admin.conf
Nov 1 16:33:01.875: INFO: Waiting up to 7m0s for all (but 0) nodes to be ready
• [0.044 seconds]
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 38 Specs in 0.050 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 37 Skipped
PASS
6 tasks
|
/retest |
neolit123
force-pushed
the
1.29-super-admin-conf
branch
5 times, most recently
from
09f0c3b
to
da999c3
Compare
chendave
reviewed
Nov 2, 2023
test/e2e_kubeadm/admin_test.go
Outdated
| } | ||
|
|
||
| // If the version is older than the version when this feature was added, skip this test | ||
| minVer := version.MustParseSemantic("v1.29.0-alpha.2.186+30ed50d32e3557") |
There was a problem hiding this comment.
How about moving ahead the version (05076de57fc49f) a little bit when the flaky issue was fixed?
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 629b5d64d83bc62adae427d5e1b16391f0e8bc8f
|
Add a test that checks if the CRB (kubeadm:cluster-admins) used for binding admin.conf file users (part of the kubeadm:cluster-admins Group) to the "cluster-admins" ClusterRole exists in kubeadm clusters. It does that only for versions newer than the version when this feature was added.
neolit123
force-pushed
the
1.29-super-admin-conf
branch
from
da999c3
to
4c53221
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm thanks @neolit123 ! |
k8s-ci-robot
added
lgtm
|
LGTM label has been added. Git tree hash: 902e787ac29b19fed03ce6bb6296b85a746fc80f
|
|
/retest |
logged ticket for flakes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area test
What this PR does / why we need it:
Add a test that checks if the CRB (kubeadm:cluster-admins) used for binding admin.conf file users (part of the kubeadm:cluster-admins Group) to the "cluster-admins" ClusterRole exists in kubeadm clusters.
It does that only for versions newer than the version when this feature was added.
Which issue(s) this PR fixes:
xref kubernetes/kubeadm#2414
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: