Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "list_type_missing" API violations in meta/v1 #121759

Merged
merged 18 commits into from
Dec 13, 2023
Merged

Fix "list_type_missing" API violations in meta/v1 #121759

merged 18 commits into from
Dec 13, 2023

Commits on Nov 27, 2023

  1. Fix "list_type_missing" API violations in meta/v1 

    This assumes that any such field is atomic, except:
  * OwnerReferences: because it has a `+patchStrategy=merge`, but it
    probably needs a `+listMapKey=...` ?
  * Finalizers: because it hs a `+patchStrategy=merge`, but is a
    primitive type (string).
  * []byte fields, which should not be failing this anyway (fixed
    subsequently).

An alternative approach could be just to turn off the API warnings for
these fields, but it felt more correct to declare the semantics.
    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    44060fb View commit details
    Browse the repository at this point in the history

  2. Re-vendor k8s.io/kube-openapi 

    ./hack/pin-dependency.sh k8s.io/kube-openapi 778a5567bc1edaed92a4de9c07f90199c67953fa

./hack/update-vendor.sh
    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1f55357 View commit details
    Browse the repository at this point in the history

  3. Re-run codegen with new kube-openapi

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    dd80194 View commit details
    Browse the repository at this point in the history

  4. Fix list_type_missing in apiextensions-apiserver

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e9bd926 View commit details
    Browse the repository at this point in the history

  5. Fix list_type_missing in sample-apiserver

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b8982be View commit details
    Browse the repository at this point in the history

  6. Fix list_type_missing in api/admissionregistration

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    460df86 View commit details
    Browse the repository at this point in the history

  7. Fix list_type_missing in api/apps

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    a3ea994 View commit details
    Browse the repository at this point in the history

  8. Fix list_type_missing in api/authentication

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b24cffb View commit details
    Browse the repository at this point in the history

  9. Fix list_type_missing in api/authorization

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ad39737 View commit details
    Browse the repository at this point in the history

  10. Fix list_type_missing in api/autoscaling

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fe902f7 View commit details
    Browse the repository at this point in the history

  11. Fix list_type_missing in api/core

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cfe1466 View commit details
    Browse the repository at this point in the history

  12. Fix list_type_missing in api/extensions

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    cddfa43 View commit details
    Browse the repository at this point in the history

  13. Fix list_type_missing in api/imagepolicy

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    7fc3ef1 View commit details
    Browse the repository at this point in the history

  14. Fix list_type_missing in api/networking

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b2458e4 View commit details
    Browse the repository at this point in the history

  15. Fix list_type_missing in api/rbac

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e96578f View commit details
    Browse the repository at this point in the history

  16. Fix list_type_missing in api/storage

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    58fb9f6 View commit details
    Browse the repository at this point in the history

  17. Fix list_type_missing in k8s.io/metrics

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    18f3941 View commit details
    Browse the repository at this point in the history

  18. Fix list_type_missing in k8s.io/apiserver

    @thockin
    thockin committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    eddf658 View commit details
    Browse the repository at this point in the history