New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use -trimpath in non-DBG mode #121894
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
LGTM label has been added. Git tree hash: 5b9ef824689956be458c8f2f909dbf561b6e99e2
|
/priority critical-urgent Looks like we will be able to have reproducible builds (almost!) with this fix. will add milestone when the CI goes green. /retest |
/retest |
The test-failure is verify-conformance-yaml throwing "Error looking for conformance data: open k8s.io/kubernetes/test/e2e/apimachinery/webhook.go: no such file or directory" So changing it from a local filepath into a kube module name DOES have some impact. Investigating |
So, gingko uses runtime.Caller() which this changes. Go team says "You can get the file path for a give package import path..." which is not obvious from code. |
f72e3db
to
ced99f7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
33033fd
to
9f8f55a
Compare
/retest |
/retest needs LGTM after rebase |
/retest |
still needs LGTM after rebase |
Still needs LGTM |
/lgtm |
LGTM label has been added. Git tree hash: fcfb8d5212326678bed73f5efebd022fb920a15e
|
@thockin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…#121894-origin-release-1.27 Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
…#121894-origin-release-1.28 Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
…#121894-origin-release-1.26 Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
…#121894-origin-release-1.29 Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
Fixes #110928
/kind bug