Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use -trimpath in non-DBG mode #121894

Merged
merged 2 commits into from Dec 29, 2023

Conversation

thockin
Copy link
Member

@thockin thockin commented Nov 15, 2023

Fixes #110928

/kind bug

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 15, 2023
@thockin thockin added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@dims
Copy link
Member

dims commented Nov 15, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b9ef824689956be458c8f2f909dbf561b6e99e2

@dims
Copy link
Member

dims commented Nov 15, 2023

/priority critical-urgent

Looks like we will be able to have reproducible builds (almost!) with this fix. will add milestone when the CI goes green.

/retest

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 15, 2023
@thockin
Copy link
Member Author

thockin commented Nov 15, 2023

/retest

@thockin
Copy link
Member Author

thockin commented Nov 15, 2023

The test-failure is verify-conformance-yaml throwing "Error looking for conformance data: open k8s.io/kubernetes/test/e2e/apimachinery/webhook.go: no such file or directory"

So changing it from a local filepath into a kube module name DOES have some impact. Investigating

@thockin
Copy link
Member Author

thockin commented Nov 16, 2023

So, gingko uses runtime.Caller() which this changes. Go team says "You can get the file path for a give package import path..." which is not obvious from code.

@k8s-ci-robot k8s-ci-robot removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 16, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member Author

thockin commented Nov 27, 2023

/retest

@thockin
Copy link
Member Author

thockin commented Nov 30, 2023

/retest

needs LGTM after rebase

@thockin
Copy link
Member Author

thockin commented Dec 11, 2023

/retest

@thockin
Copy link
Member Author

thockin commented Dec 13, 2023

still needs LGTM after rebase

@thockin
Copy link
Member Author

thockin commented Dec 28, 2023

Still needs LGTM

@dims
Copy link
Member

dims commented Dec 29, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcfb8d5212326678bed73f5efebd022fb920a15e

@k8s-ci-robot
Copy link
Contributor

@thockin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-integration 9f8f55a link unknown /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 58d023e into kubernetes:master Dec 29, 2023
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 29, 2023
@thockin thockin deleted the build_trimpath branch March 10, 2024 00:48
k8s-ci-robot added a commit that referenced this pull request Apr 8, 2024
…#121894-origin-release-1.27

Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
k8s-ci-robot added a commit that referenced this pull request Apr 8, 2024
…#121894-origin-release-1.28

Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
k8s-ci-robot added a commit that referenced this pull request Apr 8, 2024
…#121894-origin-release-1.26

Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
k8s-ci-robot added a commit that referenced this pull request Apr 11, 2024
…#121894-origin-release-1.29

Automated cherry pick of #121894: build: use -trimpath in non-DBG mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubernetes-1.24.0 reproducible builds: kubelet binary varies
4 participants