Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubedns and nodelocaldns to v1.22.28 #121908

Merged
merged 1 commit into from Dec 14, 2023
Merged

Update kubedns and nodelocaldns to v1.22.28 #121908

merged 1 commit into from Dec 14, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Nov 15, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update kubedns and nodelocaldns versions. See release: 1.22.28.

Which issue(s) this PR fixes:
Fixes NONE #

Does this PR introduce a user-facing change?:
NONE

Update kubedns and nodelocaldns to release version 1.22.28

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 15, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Nov 15, 2023

/sig cloud-provider
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 15, 2023
@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Nov 15, 2023
MrHohn
MrHohn approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
cc @DamianSawicki

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 167c8b39da5eaec6e7984a819179b5f5b9847efc

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@MrHohn
Copy link
Member

MrHohn commented Nov 15, 2023

Actually, holding to check if we need to do manual promotion in https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-dns/images.yaml.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@MrHohn
Copy link
Member

MrHohn commented Nov 15, 2023

Looks like that was done in kubernetes/k8s.io#6068.

https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-dns/images.yaml is the new image manifest location.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@DamianSawicki
Copy link
Contributor

Shouldn't we make a release fot the latest tag https://github.com/kubernetes/dns/releases/tag/1.22.28 and bump to that?

@MrHohn
Copy link
Member

MrHohn commented Nov 15, 2023

Shouldn't we make a release fot the latest tag https://github.com/kubernetes/dns/releases/tag/1.22.28 and bump to that?

Thanks, I missed that - @mzaian let's pick 1.22.28 instead as there are CVE fixes.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@DamianSawicki
Copy link
Contributor

New release created https://github.com/kubernetes/dns/releases/tag/1.22.28. Some time is certainly needed for the images to build.

@mzaian
Copy link
Contributor Author

mzaian commented Nov 16, 2023

Thanks a lot for your feedback. I created kubernetes/k8s.io#6088 to promote the images. Once merged I will update this PR to point to 1.22.28

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@DamianSawicki
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f989e09320043fe9f2cfeabbb2a6b3c6ab141924

@mzaian
Copy link
Contributor Author

mzaian commented Nov 28, 2023

kubernetes/k8s.io#6088 Is merged now

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@DamianSawicki
Copy link
Contributor

I think this is ready to be merged, thank you @mzaian!

@aojea
Copy link
Member

aojea commented Nov 29, 2023

I think this is ready to be merged, thank you @mzaian!

we are in code freeze, until master branc opens again next week this can not merge

@pacoxu
Copy link
Member

pacoxu commented Dec 14, 2023

#121736 bump to v1.22.27.

/retest

@mzaian mzaian changed the title Update kubedns and nodelocaldns versions Update kubedns and nodelocaldns to v1.22.28 Dec 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Dec 14, 2023

#121736 bump to v1.22.27.

/retest

Rebase is done and resolved all the conflicts

@DamianSawicki
Copy link
Contributor

Thanks @mzaian!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ed8c6caaf6ab48e7178a2061b3d3ebd573f0129

@mzaian
Copy link
Contributor Author

mzaian commented Dec 14, 2023

/retest

@mzaian mzaian requested a review from pacoxu December 14, 2023 15:57
@k8s-ci-robot k8s-ci-robot merged commit 3ca88dc into kubernetes:master Dec 14, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

@DamianSawicki DamianSawicki Awaiting requested review from DamianSawicki

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@MrHohn MrHohn

@DamianSawicki DamianSawicki

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mzaian @k8s-ci-robot @MrHohn @DamianSawicki @aojea @pacoxu