New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(nodevolumelimits): return UnschedulableAndUnresolvable when PVC is not found #121952
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
da1f065
to
a7f566e
Compare
/hold To go thru two reviews. |
a7f566e
to
2cea805
Compare
@@ -78,6 +79,7 @@ func (pl *CSILimits) EventsToRegister() []framework.ClusterEventWithHint { | |||
return []framework.ClusterEventWithHint{ | |||
{Event: framework.ClusterEvent{Resource: framework.CSINode, ActionType: framework.Add}}, | |||
{Event: framework.ClusterEvent{Resource: framework.Pod, ActionType: framework.Delete}}, | |||
{Event: framework.ClusterEvent{Resource: framework.PersistentVolumeClaim, ActionType: framework.Add}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take on implementing it as part of #118893.
/hold waiting for #121953 |
/unhold #121953 is merged. |
2cea805
to
e4d34a2
Compare
/hold To go thru two reviews. |
e4d34a2
to
640b7fe
Compare
640b7fe
to
bf1b3a1
Compare
@kubernetes/sig-scheduling-approvers Sorry for rushing, can anyone take a review for this? It'll block #121508. |
/assign @msau42 |
/lgtm I think this makes sense, but it would be good to have @msau42 double check. |
LGTM label has been added. Git tree hash: 891a973a766cc81aeced0d606ef9f6e2ea3e37f2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first thought is can we return Pending when PVC not found, it's similar to DRA waiting for allocation.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
When PVC is not found, currently, we return Error from the plugin.
When error is returned from the plugin, the scheduler keeps retrying this Pod's scheduling because the scheduler doesn't put pods failed by Error status into unschedQ.
This PR makes nodevolumelimits return UnschedulableAndUnresolvable when PVC is not found, and register PVC added event in EventsToRegister so that the scheduling queue retry the Pod only when PVC is created.
In the future, it'll be wiser via QHint as part of #118893 when to retry scheduling, but this PR doesn't do that for now.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: