Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #122022: fix: requeue pods rejected by Extenders properly #122044

Merged
merged 1 commit into from Dec 19, 2023
Merged

Automated cherry pick of #122022: fix: requeue pods rejected by Extenders properly #122044

merged 1 commit into from Dec 19, 2023

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Nov 26, 2023 •
edited

Cherry pick of #122022 on release-1.27.

#122022: fix: requeue pods rejected by Extenders properly

For details on the cherry pick process, see the cherry pick requests page.

The scheduling queue didn't notice any extenders' failures, it could miss some cluster events,
and it could end up Pods rejected by Extenders stuck in unschedulable pod pool in 5min in the worst-case scenario.
Now, the scheduling queue notices extenders' failures and requeue Pods rejected by Extenders appropriately.

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Nov 26, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 26, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 26, 2023
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Nov 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 26, 2023
@sanposhiho
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 26, 2023
@sanposhiho
Copy link
Member Author

/assign @alculquicondor

@sanposhiho sanposhiho force-pushed the automated-cherry-pick-of-#122022-upstream-release-1.27 branch from dccdd1c to bc5cbac Compare November 26, 2023 07:19
sanposhiho
sanposhiho commented Nov 26, 2023
View reviewed changes
pkg/scheduler/framework/runtime/framework.go
@@ -313,6 +313,13 @@ func NewFramework(r Registry, profile *config.KubeSchedulerProfile, stopCh <-cha
// Update ClusterEventMap in place.
fillEventToPluginMap(p, options.clusterEventMap)
}
if len(f.extenders) > 0 {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as v1.26, it's something different from the original PR.

#122043 (comment)

@sanposhiho sanposhiho force-pushed the automated-cherry-pick-of-#122022-upstream-release-1.27 branch from bc5cbac to f899a31 Compare November 26, 2023 08:02
@sanposhiho
Copy link
Member Author

/retest

1 similar comment
@sanposhiho
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member

/lgtm
/approve
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team November 27, 2023 13:26
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 995c413668e38a837bac28bec0a944bdf0a38571

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@saschagrunert
Copy link
Member

Raising a question in #122043 (comment)

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, sanposhiho, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanposhiho
Copy link
Member Author

🤔
Seems many of cherry-pick PRs are suffering from the same error from CI.

@xmudrii
Copy link
Member

xmudrii commented Dec 14, 2023

/test pull-kubernetes-dependencies

@sanposhiho
Copy link
Member Author

/retest

@sanposhiho
Copy link
Member Author

@kubernetes/release-managers Any idea about the dependencies job failing? My another cherry-pick is blocked by the same: #122043, but I have no idea since it doesn't add any new dependency.

@saschagrunert
Copy link
Member

/retest

@saschagrunert
Copy link
Member

@sanposhiho can you apply the fix manually?

@sanposhiho
Copy link
Member Author

/retest

@sanposhiho
Copy link
Member Author

Given /retest somehow works in #122043 (comment), let me retry it several times. I'll have a direct fix for that if not works.

@k8s-ci-robot k8s-ci-robot merged commit 39782f8 into kubernetes:release-1.27 Dec 19, 2023
14 checks passed
@sanposhiho
Copy link
Member Author

sanposhiho commented Dec 19, 2023 •
edited

OK, retry worked 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@chendave chendave Awaiting requested review from chendave

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanposhiho @k8s-ci-robot @alculquicondor @saschagrunert @xmudrii