Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep-terminated-pod-volumes flag on kubelet is removed #122082

Merged
merged 1 commit into from Apr 18, 2024
Merged

keep-terminated-pod-volumes flag on kubelet is removed #122082

merged 1 commit into from Apr 18, 2024
+70 −219

Conversation

carlory
Copy link
Member

@carlory carlory commented Nov 28, 2023 •
edited by thockin

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

keep-terminated-pod-volumes flag on kubelet is deprecated in 1.8.

FYI:

Which issue(s) this PR fixes:

Ref #45615

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED: 
Kubelet flag `--keep-terminated-pod-volumes` was removed.  This flag was deprecated in 2017.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Nov 28 04:03:42 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet labels Nov 28, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/test needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2023
@carlory
Copy link
Member Author

carlory commented Nov 28, 2023

/cc @gnufied

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Nov 28, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Nov 28, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Nov 28, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Nov 29, 2023
@carlory
Copy link
Member Author

carlory commented Jan 5, 2024

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot removed the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
@carlory carlory force-pushed the remove-keep-terminated-pod-volumes branch from 784ccfc to 5bfeb53 Compare March 1, 2024 10:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024
@carlory
Copy link
Member Author

carlory commented Mar 1, 2024

rebased upstream to resolve confliction.

/cc @bart0sh @mrunalp @sjenning

@carlory carlory force-pushed the remove-keep-terminated-pod-volumes branch from 5bfeb53 to b47c73e Compare March 1, 2024 10:42
@carlory
Copy link
Member Author

carlory commented Mar 3, 2024

/retest

@carlory
Copy link
Member Author

carlory commented Mar 6, 2024

/test pull-kubernetes-e2e-gce-storage-slow

@carlory
Copy link
Member Author

carlory commented Mar 26, 2024

/cc @bart0sh @mrunalp @sjenning

@bart0sh
Copy link
Contributor

bart0sh commented Mar 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 511a73fc7065e82ada9916b58af7512deb76e5f8

mrunalp
mrunalp approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@carlory
Copy link
Member Author

carlory commented Mar 29, 2024 •
edited

/cc @pohly @dims

For a test review.

@k8s-ci-robot k8s-ci-robot requested review from dims and pohly March 29, 2024 03:15
@carlory
Copy link
Member Author

carlory commented Mar 29, 2024

/assign @thockin

@thockin
Copy link
Member

thockin commented Apr 6, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane, mrunalp, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef2c682 into kubernetes:master Apr 18, 2024
19 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 18, 2024
@carlory carlory deleted the remove-keep-terminated-pod-volumes branch April 18, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@humblec humblec Awaiting requested review from humblec

@mattcary mattcary Awaiting requested review from mattcary

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@bart0sh bart0sh Awaiting requested review from bart0sh

@sjenning sjenning Awaiting requested review from sjenning

@dims dims Awaiting requested review from dims

@pohly pohly Awaiting requested review from pohly

Assignees

@gnufied gnufied

@mrunalp mrunalp

@sjenning sjenning

@jsafrane jsafrane

@thockin thockin

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Done
SIG Node CI/Test Board
Archive-it
SIG Node PR Triage
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@carlory @k8s-ci-robot @bart0sh @jsafrane @thockin @mrunalp @gnufied @sjenning