New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/tools: bump logtools to v0.8.0 #122436
Conversation
This adds support for marking functions and methods as "don't use in code which supports contextual logging".
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig instrumentation |
/lgtm |
LGTM label has been added. Git tree hash: 1b181fd8b2e590acb4cebe743dbaae1cbd2214f9
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds support for marking functions and methods as "don't use in code which supports contextual logging".
Special notes for your reviewer:
I found that I had to do
_output/local/bin/golangci-lint cache clean
to get rid of some false positives after the update:This stopped being reported (as it should be, because the first if calls framework.Failf and that doesn't proceed) after cleaning the cache. Somehow the new fact in logcheck interfered with with the fact from staticcheck.
Does this PR introduce a user-facing change?