Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/tools: bump logtools to v0.8.0 #122436

Merged
merged 1 commit into from Dec 22, 2023

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Dec 21, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds support for marking functions and methods as "don't use in code which supports contextual logging".

Special notes for your reviewer:

I found that I had to do _output/local/bin/golangci-lint cache clean to get rid of some false positives after the update:

ERROR: test/e2e/network/endpointslice.go:993:5: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
ERROR: 	if targetRef == nil {
ERROR: 	   ^
ERROR: test/e2e/network/endpointslice.go:996:15: SA5011: possible nil pointer dereference (staticcheck)
ERROR: 	if targetRef.Kind != "Pod" {
ERROR: 	             ^

This stopped being reported (as it should be, because the first if calls framework.Failf and that doesn't proceed) after cleaning the cache. Somehow the new fact in logcheck interfered with with the fact from staticcheck.

Does this PR introduce a user-facing change?

NONE

This adds support for marking functions and methods as "don't use in code which
supports contextual logging".
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes labels Dec 21, 2023
@pohly
Copy link
Contributor Author

pohly commented Dec 21, 2023

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 21, 2023
@cblecker
Copy link
Member

/lgtm
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 21, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b181fd8b2e590acb4cebe743dbaae1cbd2214f9

@pacoxu
Copy link
Member

pacoxu commented Dec 22, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 40c729c into kubernetes:master Dec 22, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants