New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overrides for registered feature defaults. #122647
Support overrides for registered feature defaults. #122647
Conversation
/assign @p0lyn0mial |
/triage accepted |
a0990b9
to
1200158
Compare
1200158
to
26fdfe1
Compare
/lgtm /assign @deads2k for approval |
LGTM label has been added. Git tree hash: bb4a8bb76dd6bea03d6d2f3c550c5a9b0f32ebea
|
26fdfe1
to
c4101fb
Compare
c4101fb
to
1eaa7db
Compare
This is to support the goal of enabling a feature by default for a single component only when the feature in question is consumed by multiple components. Overriden defaults are reflected in KnownFeatures and registered flag text.
1eaa7db
to
46d0e1d
Compare
/lgtm |
LGTM label has been added. Git tree hash: d089ea9a37426f72989bb8d8b6eb7b20a2a3d747
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@benluddy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-e2e-kind-ipv6 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is to support the goal of enabling a feature by default for a single component only when the feature in question is consumed by multiple components.
Overriden defaults are reflected in KnownFeatures and registered flag text.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For beta, KEP 3157 proposes to enable a client-side feature gate by default in kube-controller-manager only.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: