Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overrides for registered feature defaults. #122647

Merged

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Jan 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This is to support the goal of enabling a feature by default for a single component only when the feature in question is consumed by multiple components.

Overriden defaults are reflected in KnownFeatures and registered flag text.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

For beta, KEP 3157 proposes to enable a client-side feature gate by default in kube-controller-manager only.

Does this PR introduce a user-facing change?

Added to MutableFeatureGate the ability to override the default setting of feature gates, to allow default-enabling a feature on a component-by-component basis instead of for all affected components simultaneously.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Proposal]: https://docs.google.com/document/d/1g9BGCRw-7ucUxO6OtCWbb3lfzUGA_uU9178wLdXAIfs/edit#heading=h.ookhkzz1jrsp

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2024
@benluddy
Copy link
Contributor Author

benluddy commented Jan 8, 2024

/assign @p0lyn0mial

@leilajal
Copy link
Contributor

leilajal commented Jan 9, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2024
@benluddy benluddy force-pushed the featuregate-default-runtime-override branch from a0990b9 to 1200158 Compare January 10, 2024 17:20
@benluddy benluddy force-pushed the featuregate-default-runtime-override branch from 1200158 to 26fdfe1 Compare January 11, 2024 14:18
@p0lyn0mial
Copy link
Contributor

/lgtm

/assign @deads2k

for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bb4a8bb76dd6bea03d6d2f3c550c5a9b0f32ebea

@benluddy benluddy force-pushed the featuregate-default-runtime-override branch from 26fdfe1 to c4101fb Compare January 11, 2024 20:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2024
@benluddy benluddy force-pushed the featuregate-default-runtime-override branch from c4101fb to 1eaa7db Compare January 12, 2024 14:38
This is to support the goal of enabling a feature by default for a single component only when the
feature in question is consumed by multiple components.

Overriden defaults are reflected in KnownFeatures and registered flag text.
@benluddy benluddy force-pushed the featuregate-default-runtime-override branch from 1eaa7db to 46d0e1d Compare January 12, 2024 15:25
@deads2k
Copy link
Contributor

deads2k commented Jan 12, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d089ea9a37426f72989bb8d8b6eb7b20a2a3d747

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 12, 2024

@benluddy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-cos-alpha-features c4101fb link false /test pull-kubernetes-e2e-gce-cos-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 83e6636 into kubernetes:master Jan 12, 2024
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants