Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshooting for misplaced/misspelled fields #12296

Merged
merged 1 commit into from Aug 6, 2015

Conversation

erictune
Copy link
Member

@erictune erictune commented Aug 5, 2015

Inspired to write this while helping user with issue #12278.
For v1.0.2 this is necessary advice.
So, this should get cherry-picked to v1.0.
This may be fixed by #11914. Therefore:

@erictune
Copy link
Member Author

erictune commented Aug 5, 2015

Should be cherry-picked to v1.0.3. Only a docs change.

@k8s-bot
Copy link

k8s-bot commented Aug 5, 2015

GCE e2e build/test passed for commit 1ce1c54.

@nikhiljindal nikhiljindal self-assigned this Aug 5, 2015
@nikhiljindal
Copy link
Contributor

Yes. We wont cherrypick 11914.
Doc change LGTM.
Thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2015
@wojtek-t wojtek-t closed this Aug 6, 2015
@wojtek-t wojtek-t reopened this Aug 6, 2015
@wojtek-t
Copy link
Member

wojtek-t commented Aug 6, 2015

Closed & reopened to trigger Shippable.

@wojtek-t
Copy link
Member

wojtek-t commented Aug 6, 2015

It seems that Shippable failure is a real one/
@erictune can you please rebase it (this will hopefully help)

wojtek-t added a commit that referenced this pull request Aug 6, 2015
Troubleshooting for misplaced/misspelled fields
@wojtek-t wojtek-t merged commit 4244a7c into kubernetes:master Aug 6, 2015
brendandburns added a commit that referenced this pull request Aug 7, 2015
…96-upstream-release-1.0

Automated cherry pick of #12296
@brendandburns brendandburns mentioned this pull request Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants