Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: Build image v3.5.12 #123069

Merged
merged 1 commit into from Feb 5, 2024
Merged

etcd: Build image v3.5.12 #123069

merged 1 commit into from Feb 5, 2024

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Feb 1, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Build image v3.5.12

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Build etcd image v3.5.12

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

none

@bzsuni
build etcd image v3.5.12
1db6e43 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2024
@mzaian
Copy link
Contributor

mzaian commented Feb 1, 2024

Hello @bzsuni

Please update the release-note

/retest

@pacoxu
Copy link
Member

pacoxu commented Feb 1, 2024

/sig etcd
/lgtm
/assign @jpbetz, @justaugustus

@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c0bdb50dd8bdf09b5ca6037b868ac593f0e79e5

@pacoxu
Copy link
Member

pacoxu commented Feb 1, 2024

/assign @jpbetz @justaugustus

justaugustus
justaugustus approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required
/lgtm
/approve

@bzsuni
Copy link
Contributor Author

bzsuni commented Feb 1, 2024

/retest-required

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2024
@Jefftree
Copy link
Member

Jefftree commented Feb 1, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 1, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Feb 2, 2024

Hello @bzsuni

Please update the release-note

/retest

Done. Thanks

@dims
Copy link
Member

dims commented Feb 5, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Feb 5, 2024

/retest

@bzsuni
Copy link
Contributor Author

bzsuni commented Feb 5, 2024

/test pull-kubernetes-node-e2e-containerd

@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2024

/hold
as #123127 will fail pull-kubernetes-node-e2e-containerd which is required CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2024
@pacoxu
Copy link
Member

pacoxu commented Feb 5, 2024

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit 003187f into kubernetes:master Feb 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 5, 2024
@pacoxu
Copy link
Member

pacoxu commented Feb 6, 2024

Etcd 3.5.12 fixed some bugs, and should this be cherry-picked to v1.26~1.29? @ahrtr @serathius

@ahrtr
Copy link
Member

ahrtr commented Feb 6, 2024

Etcd 3.5.12 fixed some bugs, and should this be cherry-picked to v1.26~1.29? @ahrtr @serathius

Yes, it's always recommended to bump to the latest version.

@pacoxu pacoxu mentioned this pull request Feb 7, 2024
Merged
@pacoxu
Copy link
Member

pacoxu commented Feb 7, 2024

This PR is for the image build.

And #123150 needs check-pick.

@bzsuni bzsuni mentioned this pull request Feb 8, 2024
Merged
This was referenced Feb 8, 2024
Closed
Merged
@bzsuni bzsuni mentioned this pull request Feb 8, 2024
Closed
@humblec humblec mentioned this pull request Feb 8, 2024
Merged
@bzsuni bzsuni mentioned this pull request Feb 8, 2024
Closed
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123198 from humblec/automated-cherry-pick-of-#123…
97cc9b5 
…069-#123150-upstream-release-1.27

Automated cherry pick of #123069: build etcd image v3.5.12
#123150: etcd: Update to version 3.5.12
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123188 from bzsuni/automated-cherry-pick-of-#123069-
173889a 
#123150-upstream-release-1.29

Automated cherry pick of #123069: build etcd image v3.5.12
#123150: etcd: Update to version 3.5.12
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123196 from humblec/automated-cherry-pick-of-#123…
7c70582 
…069-#123150-upstream-release-1.28

Automated cherry pick of #123069: build etcd image v3.5.12
#123150: etcd: Update to version 3.5.12
@liangyuanpeng liangyuanpeng mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@dims dims

@jpbetz jpbetz

@justaugustus justaugustus

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bzsuni @mzaian @pacoxu @k8s-ci-robot @Jefftree @dims @ahrtr @justaugustus @jpbetz