Revert "kubeadm: fix a bug where the uploaded kubelet configuration in kube-system/kubelet-config ConfigMap does not respect user patch"

[SataQiu]

What type of PR is this?

/kind bug

What this PR does / why we need it:

revert kubeadm: fix a bug where the uploaded kubelet configuration in kube-system/kubelet-config ConfigMap does not respect user patch

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#3008

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fixes a 1.27.0+ regression in kubeadm: do not upload kubelet patch configuration into `kube-system/kubelet-config` ConfigMap

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [SataQiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

/lgtm
/hold

should we backport to 1.27, 1.28, 1.29?
users have a workaround to just always apply a patch on all nodes.
tentative +1 for backport

/cc @pacoxu

[neolit123]

with the original PR were we trying to fix a bug or a problem in e2e tests?
i'm trying to understand what implications does this have on upgrades too.
i guess on upgrade if the user passes --patches they would only apply on the local upgraded node, which is expected.
i.e. not apply the patch on the CM, from "upgrade node" from a CP node.

[SataQiu]

I think yes, the upgrade also does not require applying these patches to the global ConfigMap.
/retest

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5c7659695740a45ec6c34ab1b2ce718f8caad034

[SataQiu]

+1 for backport

[neolit123]

+1 for backport

please send backports for these releases if you can, once this merges.
if not i can try to send in the next few days.

[neolit123]

/hold cancel

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest