Fix daemonset to ensure old unhealthy pods are counted towards max unavailable budget.

[marshallbrekka]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes a bug in the daemonset update logic where old pods that are not available are not correctly counted against the maxUnavailable budget.

Which issue(s) this PR fixes:

Fixes #123232

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Ensure daemonset controller to count old unhealthy pods towards max unavailable budget

[k8s-ci-robot]

Welcome @marshallbrekka!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @marshallbrekka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marshallbrekka]

I believe this commit is what introduced the regression, with the consolidation of unavailable logic.

Here was the logic in the prior commit

kubernetes/pkg/controller/daemon/update.go

Lines 519 to 528 in 18f43e4

	for _, pod := range daemonPods {
	// for the purposes of update we ensure that the Pod is both available and not terminating
	if podutil.IsPodAvailable(pod, ds.Spec.MinReadySeconds, metav1.Time{Time: now}) && pod.DeletionTimestamp == nil {
	available = true
	break
	}
	}
	if !available {
	numUnavailable++
	}

[marshallbrekka]

@kow3ns / @soltysh Just wondering if you have an estimate for when you will be able to take a look at this?

[soltysh]

/triage accepted
/priority important-longterm
/ok-to-test

[soltysh]

@kow3ns / @soltysh Just wondering if you have an estimate for when you will be able to take a look at this?

this looks good, let's wait for green CI and then I'll tag, thank you! And sorry for the long delay 😅

[soltysh]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 4ca06c5d9a9e6ceddb9511650a261d2e125d9f40

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marshallbrekka, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/daemon/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment