New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: fix flaky unit test with TestRotateLogs due to improper handling of goroutine in the tests #123469
kubelet: fix flaky unit test with TestRotateLogs due to improper handling of goroutine in the tests #123469
Conversation
…ling of goroutine in the tests
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @kannon92 @dims @Rajalakshmi-Girish PTAL |
/approve |
LGTM label has been added. Git tree hash: 7184e887a34742899a056167c41a54be900b7f99
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, harshanarayana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
/kind flake
What this PR does / why we need it:
Fix the
TestRotateLogs
function in kubelet's UTs to handle the invocation ofprocessQueueItems
properly. This was added by changes introduced in #114301.The test was flaking due to improper handling of the routines leading to flaky test failures when running under stress.
Which issue(s) this PR fixes:
Fixes #123414
Special notes for your reviewer:
Additional details on what lead to the issue can be found in the comment #123414 (comment)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: