New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fmt.Print with printer in upgrade plan code and fix configVersions are not printed when output is json or yaml #123492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI errors need to be fixed, but LGTM
works locally too.
/triage accepted
/priority backlog
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlory, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
you can remove the text in the box under, it's not needed for this PR. |
…sions are not printed when output is json or yaml
219a4c8
to
fb3ab53
Compare
/cc @pacoxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
to unblock #123461
LGTM label has been added. Git tree hash: df44b4e56f0b210b670773e9556ffdb677dbd5fd
|
Changelog suggestion -kubeadm: fix a bug where "kubeadm upgrade plan -o yaml|json" includes unneeded output and was missing component config information.
+kubeadm: fixed a bug where `kubeadm upgrade plan -o yaml|json` included unneeded output,
+and was missing component config information. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Ref kubernetes/kubeadm#494
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: