-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conditional endPort printing for NetworkPolicies #123507
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @kennedn! |
Hi @kennedn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kennedn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Similar to #123316 |
We avoid referencing issues in commit messages |
Changelog suggestion -Added port range information when describing a NetworkPolicy that had endPort set.
+Fixed a bug where `kubectl describe` incorrectly displayed NetworkPolicy port ranges
+(showing only the starting port). |
/ok-to-test |
/triage accepted |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a conditional to the networkpolicy print logic to print information about endPort.
Which issue(s) this PR fixes:
Fixes #123506
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: