Automated cherry pick of #123570: Filter aggregated apiservice gv #123624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
|
/kind bug Will let @kubernetes/release-team-leads provide cherry-pick approval once tests pass. |
k8s-ci-robot
added
release-note
k8s-ci-robot
added
lgtm
|
/assign @liggitt |
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
liggitt
reviewed
Mar 6, 2024
| return aggregator.FilterSpecByPathsWithoutSideEffects(result, []string{"/apis/"}), etag, nil | ||
| group := specInfo.apiService.Spec.Group | ||
| version := specInfo.apiService.Spec.Version | ||
| return aggregator.FilterSpecByPathsWithoutSideEffects(result, []string{"/apis/" + group + "/" + version}), etag, nil |
There was a problem hiding this comment.
is the trailing slash the path prefix had previously (/apis/) significant?
the new prefix does not end in a slash... does this mean APIService group=foo, version=v1 can return /apis/foo/v1beta1 stuff and have it included?
There was a problem hiding this comment.
yes, thanks for catching this. Opened #123770
k8s-ci-robot
added
area/test
sig/testing
|
/retest |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3e7fc7518335fa8415be4c5b573f6c9467574dbc
|
|
/cc kubernetes/release-managers |
saschagrunert
approved these changes
Apr 5, 2024
k8s-ci-robot
added
cherry-pick-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Jefftree, saschagrunert, shyamjvs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #123570 on release-1.29.
#123570: Filter aggregated apiservice gv
Also includes #123770
For details on the cherry pick process, see the cherry pick requests page.