New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid clearing go version in go.work update script #123759
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig architecture |
/milestone v1.30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
LGTM label has been added. Git tree hash: 652d6f4bd87aba294e915fe6c5156cadb721f2fe
|
/approve |
Should we clarify the header? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, liggitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Short-term fix to avoid stomping the go version in the go.work file during update-go-workspace.sh.
Needed to unblock #123750
As a follow-up, I plan to fold this file into update-vendor.sh
/assign @thockin @dims @cpanato