Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust GPU test to work with latest nvidia daemonset on AWS/ec2 #123776

Conversation

dims
Copy link
Member

@dims dims commented Mar 6, 2024

Getting GPU test to work on AWS/EC2 as there are some flakiness on the existing CI job.

  • areGPUsAvailableOnAllSchedulableNodes : ignore control plane node, it needed not have a GPU (we are not going to schedule on that node)
  • makeCudaAdditionDevicePluginTestPod : usually builds a pod with 2 containers (uses 1 GPU each). As in EC2/AWS, Nodes with 2 Nvidia GPU(s) are costly, let's have a environment variable TEST_MAX_GPU_COUNT to use just 1 container (with 1 GPU) as the test workload
  • reuse "NVIDIA_DRIVER_INSTALLER_DAEMONSET and point it to the latest daemonset URL needs some accomodation on the namespace logic to make it work.

See first clean run here:
https://testgrid.k8s.io/presubmits-ec2#pull-kubernetes-e2e-ec2-device-plugin-gpu&width=20

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 6, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/test pull-kubernetes-e2e-ec2-device-plugin-gpu

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the adjust-gpu-test-to-work-with-latest-nvidia-daemonset branch from a19501d to ddda25f Compare March 7, 2024 02:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/test pull-kubernetes-e2e-ec2-device-plugin-gpu

@dims dims force-pushed the adjust-gpu-test-to-work-with-latest-nvidia-daemonset branch from ddda25f to 3085765 Compare March 7, 2024 03:23
@dims dims changed the title [WIP] Adjust GPU test to work with latest nvidia daemonset Adjust GPU test to work with latest nvidia daemonset Mar 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/kind bug
/release-note-none
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 7, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Mar 7, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/assign @tzneal @upodroid @ameukam

@dims dims changed the title Adjust GPU test to work with latest nvidia daemonset Adjust GPU test to work with latest nvidia daemonset on AWS/ec2 Mar 7, 2024
@dims
Copy link
Member Author

dims commented Mar 7, 2024

/assign @pacoxu

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/hold

we should release hold if pull-kubernetes-e2e-gce-device-plugin-gpu goes green.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

/test pull-kubernetes-e2e-gce-device-plugin-gpu

after kubernetes/test-infra#32188 was merged

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/test pull-kubernetes-e2e-ec2-device-plugin-gpu

@dims
Copy link
Member Author

dims commented Mar 7, 2024

let's make sure both the ec2 and gce jobs for device-plugin-gpu go green!

@dims
Copy link
Member Author

dims commented Mar 7, 2024

pull-kubernetes-e2e-ec2-device-plugin-gpu is ✅

@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

/test pull-kubernetes-e2e-ec2-device-plugin-gpu

@pacoxu
Copy link
Member

pacoxu commented Mar 7, 2024

pull-kubernetes-e2e-ec2-device-plugin-gpu is ✅

This may fixed the ec2 test.
If so, can we use https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-ec2-device-plugin-gpu in https://testgrid.k8s.io/sig-release-master-blocking board instead of the ci-kubernetes-e2e-gce-device-plugin-gpu

My run with #123788 failed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/123788/pull-kubernetes-e2e-ec2-device-plugin-gpu/1765609958725914624.

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/skip

( skipping the pull-kubernetes-e2e-gce-device-plugin-gpu job too flaky )

@dims
Copy link
Member Author

dims commented Mar 7, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@ameukam
Copy link
Member

ameukam commented Mar 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3e1519b753aeb5e2679e4a2b57161fff663708c

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2024

@dims: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 3085765 link false /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit bf7fcfd into kubernetes:master Mar 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants