Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admission error on podresources e2e test #124010

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix admission error on podresources e2e test #124010

merged 1 commit into from
Mar 21, 2024

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Mar 20, 2024

What type of PR is this?

/kind cleanup
/kind failing-test
/kind flake

What this PR does / why we need it:

Fix UnexpectedAdmissionError: Allocate failed due to not enough cpus available to satisfy request: requested=2, available=1, which is unexpected error in e2e_node podresources tests.
The error caused by the test requesting more CPUs that the test instance has.

Here is an example of failed job: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/124000/pull-kubernetes-node-kubelet-serial-crio-cgroupv1/1770195910098161664/build-log.txt

Which issue(s) this PR fixes:

Ref: #123589

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@bart0sh
Fix admission error
2473922 
Fixed UnexpectedAdmissionError: Allocate failed due to not enough cpus
available to satisfy request: requested=2, available=1, which is unexpected
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 20, 2024

/cc @kannon92 @esotsal @SergeyKanzhelev

@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: esotsal.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kannon92 @esotsal @SergeyKanzhelev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Mar 20, 2024
@kannon92
Copy link
Contributor

/retitle Fix admission error on podresources e2e test

@k8s-ci-robot k8s-ci-robot changed the title Fix admission error Fix admission error on podresources e2e test Mar 20, 2024
@kannon92
Copy link
Contributor

IMO let's just combine #124011 into here.

@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 20, 2024

IMO let's just combine #124011 into here.

I thought about it, but decided to make 2 prs just in case one of them can raise reviewers concerns.

@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5e86fcdaa62ee0ea1073f8a619f9dad66bef948

@bart0sh
Copy link
Contributor Author

bart0sh commented Mar 20, 2024

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Mar 20, 2024
ffromani
ffromani approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this. Requiring just one exclusive CPU should be fine, the key thing is we require exclusive CPUs, and we still do.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, ffromani, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Mar 21, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 95a6f2e into kubernetes:master Mar 21, 2024
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@ffromani ffromani ffromani approved these changes

@kannon92 kannon92 Awaiting requested review from kannon92

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@kannon92 kannon92

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bart0sh @k8s-ci-robot @kannon92 @mrunalp @k8s-triage-robot @ffromani