Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Coordinated Leader Election #124012

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

[WIP] Coordinated Leader Election #124012

wants to merge 24 commits into from

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Mar 20, 2024 •
edited

/kind feature

What this PR does / why we need it:

Coordinated Leader Election Alpha

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

POC Completed:

  • Coordinated Leader Election controller implemented in apiserver
  • coordinated leader election alpha types
  • coordinated leader election implements minimum version selection

Other requirements from KEP

  • Coordinated Leader Election should enforce mutual exclusion when multiple apiservers are present
  • Identity Lease is refactored into a controller that watches IdentityLease
  • Identity leases should have long refresh rate and be prompted to renew by the coordinated leader election controller
  • Finalize naming/API
    • IdentityLease -> LeaseCandidate
    • work with labels for BinaryVersion/CompatibilityVersion
  • election algorithm should be configurable
  • basic unit and integration tests
  • I originally built upon the current lock interface using a CoordinatedLeaderElection toggle to differentiate between coordinated and the noncoordinated case. I think this probably needs to be refactored into its own interface in client-go
  • e2e tests

Does this PR introduce a user-facing change?

Coordinated Leader Election is alpha

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2024
@k8s-ci-robot k8s-ci-robot requested review from cheftako, deads2k and a team March 20, 2024 17:57
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 20, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 21, 2024
@Jefftree
Copy link
Member Author

Jefftree commented Apr 8, 2024

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 23, 2024
@Jefftree
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jefftree
Once this PR has been reviewed and has the lgtm label, please assign deads2k, liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 24, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@Jefftree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dependencies b352bb5 link true /test pull-kubernetes-dependencies
pull-kubernetes-conformance-kind-ipv6-parallel b352bb5 link false /test pull-kubernetes-conformance-kind-ipv6-parallel
pull-kubernetes-e2e-gce b352bb5 link true /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-cos-alpha-features b352bb5 link false /test pull-kubernetes-e2e-gce-cos-alpha-features
pull-kubernetes-local-e2e b352bb5 link false /test pull-kubernetes-local-e2e
pull-publishing-bot-validate b352bb5 link false /test pull-publishing-bot-validate
pull-kubernetes-linter-hints b352bb5 link false /test pull-kubernetes-linter-hints
pull-kubernetes-typecheck b352bb5 link true /test pull-kubernetes-typecheck
pull-kubernetes-verify-lint b352bb5 link true /test pull-kubernetes-verify-lint
pull-kubernetes-e2e-kind-ipv6 b352bb5 link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-kind b352bb5 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-conformance-kind-ga-only-parallel b352bb5 link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-verify b352bb5 link true /test pull-kubernetes-verify
pull-kubernetes-node-e2e-containerd b352bb5 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-integration b352bb5 link true /test pull-kubernetes-integration
pull-kubernetes-unit b352bb5 link true /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
SIG Auth
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jefftree @k8s-ci-robot @jpbetz