Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-controller-manager removes deprecated command flags #124017

Merged
merged 1 commit into from
May 28, 2024
Merged

kube-controller-manager removes deprecated command flags #124017

merged 1 commit into from
May 28, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Mar 21, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

--volume-host-cidr-denylist and --volume-host-allow-local-loopback was deprecated in v1.28. #118128

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-controller-manager removes deprecated command flags: --volume-host-cidr-denylist and --volume-host-allow-local-loopback

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 21, 2024
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 21, 2024
@carlory
Copy link
Member Author

carlory commented Mar 21, 2024

/cc @danwinship

@carlory
Copy link
Member Author

carlory commented Mar 21, 2024

/retest

@Jefftree
Copy link
Member

Seems to be gce specific tests that are failing. Does something need to be changed there?
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2024
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 22, 2024
@carlory
Copy link
Member Author

carlory commented Mar 22, 2024

Does something need to be changed there?

Fixed in https://github.com/kubernetes/kubernetes/compare/51c92cf815ef18ba136d00af80d09306780d0a30..b3b7a1dace199bf258191d9099e94f6e07d08f84

@carlory
Copy link
Member Author

carlory commented Mar 22, 2024

/retest

@bart0sh bart0sh added this to Triage in SIG Node CI/Test Board Mar 24, 2024
@bart0sh bart0sh moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 31, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2024
@Jefftree
Copy link
Member

/remove-sig api-machinery
/triage needs-triage
/sig storage

Probably a good idea to have the same reviewers as #118128

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

@Jefftree: The label(s) triage/needs-triage cannot be applied, because the repository doesn't have them.

In response to this:

/remove-sig api-machinery
/triage needs-triage
/sig storage

Probably a good idea to have the same reviewers as #118128

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@carlory
Copy link
Member Author

carlory commented May 24, 2024

/assign @thockin @danwinship

@aojea
Copy link
Member

aojea commented May 24, 2024

/assign @liggitt

liggitt
liggitt reviewed May 24, 2024
View reviewed changes
cmd/kube-controller-manager/app/options/persistentvolumebindercontroller.go
@@ -57,8 +53,6 @@ func (o *PersistentVolumeBinderControllerOptions) ApplyTo(cfg *persistentvolumec

cfg.PVClaimBinderSyncPeriod = o.PVClaimBinderSyncPeriod
cfg.VolumeConfiguration = o.VolumeConfiguration
cfg.VolumeHostCIDRDenylist = o.VolumeHostCIDRDenylist
cfg.VolumeHostAllowLocalLoopback = o.VolumeHostAllowLocalLoopback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these fields be removed from cfg type as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt removed. please take another look, thank you.

@carlory
kube-controller-manager removed deprecated command flags: --volume-ho…
214287b 
…st-cidr-denylist and --volume-host-allow-local-loopback
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2024
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented May 28, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59672a8abfcb0f8ca6f97348a37cce39bf07ff69

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1ff1207 into kubernetes:master May 28, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 28, 2024
@carlory carlory deleted the rm-ctrl-flags branch May 29, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

@xing-yang xing-yang Awaiting requested review from xing-yang

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@danwinship danwinship

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Done
SIG Node CI/Test Board
Archive-it
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@carlory @Jefftree @k8s-ci-robot @aojea @k8s-triage-robot @liggitt @danwinship @thockin