Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring unused parameter #124033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactoring unused parameter #124033

wants to merge 1 commit into from
+7 −8

Conversation

HyunSu1768
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removed unused parameters from prober.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @HyunSu1768. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 24, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0892d12325d7d4cfd22bf057b32bd3c8ff2c68a9

@HyunSu1768
Copy link
Contributor Author

/assign @Random-Liu

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Mar 24, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Mar 24, 2024

@HyunSu1768 If you're fixing this, can you also look at the rest of the cases in pkg/kubelet?
hint:

$ golangci-lint run --disable-all --enable unparam ./pkg/kubelet/... | grep unparam | wc -l
48

@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 24, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Mar 24, 2024

/triage accepted
/priority backlog
/cc

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 24, 2024
@bart0sh bart0sh added this to Triage in SIG Node CI/Test Board Mar 24, 2024
@gjkim42
Copy link
Member

gjkim42 commented Mar 25, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2024
@HyunSu1768
Copy link
Contributor Author

@HyunSu1768 If you're fixing this, can you also look at the rest of the cases in pkg/kubelet? hint:

$ golangci-lint run --disable-all --enable unparam ./pkg/kubelet/... | grep unparam | wc -l
48

Okay! I will delete unused parameters and commit.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@HyunSu1768
Copy link
Contributor Author

/retest

2 similar comments
@HyunSu1768
Copy link
Contributor Author

/retest

@HyunSu1768
Copy link
Contributor Author

/retest

@HyunSu1768
Copy link
Contributor Author

/retest-required

1 similar comment
@HyunSu1768
Copy link
Contributor Author

/retest-required

@HyunSu1768 HyunSu1768 force-pushed the hyunsu1768-delete-unsued-parameter branch from 064a59b to 54b4306 Compare March 26, 2024 02:13
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HyunSu1768, SergeyKanzhelev
Once this PR has been reviewed and has the lgtm label, please ask for approval from random-liu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HyunSu1768
Copy link
Contributor Author

HyunSu1768 commented Mar 26, 2024 •
edited

@HyunSu1768 If you're fixing this, can you also look at the rest of the cases in pkg/kubelet? hint:

$ golangci-lint run --disable-all --enable unparam ./pkg/kubelet/... | grep unparam | wc -l
48

I tried this, but there are countless changes, so it seems difficult to do in this pr. Can i solve it step by step in another pr?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 26, 2024 •
edited

@HyunSu1768: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-storage-snapshot 5eda1fe link false /test pull-kubernetes-e2e-gce-storage-snapshot

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HyunSu1768
Copy link
Contributor Author

/retest-required

@bart0sh bart0sh moved this from Triage to Archive-it in SIG Node CI/Test Board Mar 31, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Apr 14, 2024

@HyunSu1768

I tried this, but there are countless changes, so it seems difficult to do in this pr. Can i solve it step by step in another pr?

Sure, you can solve them step by step, but why not to start with this PR? Just include a couple of other directories to decrease amount of future PRs.

@HyunSu1768
Copy link
Contributor Author

@HyunSu1768

I tried this, but there are countless changes, so it seems difficult to do in this pr. Can i solve it step by step in another pr?

Sure, you can solve them step by step, but why not to start with this PR? Just include a couple of other directories to decrease amount of future PRs.

All right. Let's fix it in a way that doesn't have a big impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wzshiming wzshiming Awaiting requested review from wzshiming

@bart0sh bart0sh Awaiting requested review from bart0sh

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@Random-Liu Random-Liu

@SergeyKanzhelev SergeyKanzhelev

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archive-it
SIG Node PR Triage
Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@HyunSu1768 @k8s-ci-robot @bart0sh @gjkim42 @SergeyKanzhelev @Random-Liu