New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: API cleanup + fix #124075
DRA: API cleanup + fix #124075
Conversation
The k8s.io in the string and conventions around finalizers for DRA driver controllers implied that this is for use by Kubernetes, but it's better to be explicit about this.
It was already required via validation, but not declared as such by the OpenAPI.
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Mar 27 08:06:15 UTC 2024. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/remove-sig api-machinery |
/retest |
/lgtm |
pkg/apis/resource/namedresources.go
Outdated
// resource instance is suitable. The language is as defined in | ||
// https://kubernetes.io/docs/reference/using-api/cel/ | ||
// | ||
// In addition, for each type NamedResourcesin AttributeValue there is a map that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"NamedResourcesin" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm cancel
Will fix. How ironic that a PR that fixes typos introduces new ones...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This had been done before for types.go, but namedresources.go still had one small diff. While at it, fix some typos.
/assign @thockin |
/remove-sig api-machinery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
LGTM label has been added. Git tree hash: 7acd6533eb32f8d2a53640aec3a9d82e001874f5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This is a minor documentation and OpenAPI update. The ResourceHandle.DriverName was already required
via validation, but was not declared as such by the OpenAPI.
Does this PR introduce a user-facing change?