Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-evict pod if hard eviction threshold reached while pod is soft-evicting #124081

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

re-evict pod if hard eviction threshold reached while pod is soft-evicting #124081

wants to merge 15 commits into from
+437 −184

Commits on May 15, 2024

  1. if a pod is taking too long to evict, move on to others 

    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1cbc3d5 View commit details
    Browse the repository at this point in the history

  2. use uids instead of namespace/name, use actual set 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f5170b9 View commit details
    Browse the repository at this point in the history

  3. fix logging 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    63406d8 View commit details
    Browse the repository at this point in the history

  4. create helper manager impl function for tests 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0570f93 View commit details
    Browse the repository at this point in the history

  5. pass in args to newManagerImpl 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1426e5a View commit details
    Browse the repository at this point in the history

  6. kill func nonblocking, use semaphore to not allow concurrent soft evicts 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    957424b View commit details
    Browse the repository at this point in the history

  7. use a lock instead of a channel semaphore 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6a65e03 View commit details
    Browse the repository at this point in the history

  8. order thresholds by whether or not it is a hard threshold 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8bb7897 View commit details
    Browse the repository at this point in the history

  9. add test, clean up 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    41a37b1 View commit details
    Browse the repository at this point in the history

  10. undo accidental add 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1b9af62 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Update pkg/kubelet/eviction/eviction_manager_test.go 

    Co-authored-by: Itamar Holder <77444623+iholder101@users.noreply.github.com>
    @olyazavr @iholder101
    olyazavr and iholder101 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    87a05e9 View commit details
    Browse the repository at this point in the history

  2. Update pkg/kubelet/eviction/eviction_manager.go 

    Co-authored-by: Itamar Holder <77444623+iholder101@users.noreply.github.com>
    @olyazavr @iholder101
    olyazavr and iholder101 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    388f2fa View commit details
    Browse the repository at this point in the history

  3. Update pkg/kubelet/eviction/eviction_manager.go 

    Co-authored-by: Itamar Holder <77444623+iholder101@users.noreply.github.com>
    @olyazavr @iholder101
    olyazavr and iholder101 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5b22f01 View commit details
    Browse the repository at this point in the history

  4. add test for hard evicting a different pod 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    694c4fe View commit details
    Browse the repository at this point in the history

  5. fix lint 

    Signed-off-by: Olga Shestopalova <oshestopalova1@gmail.com>
    @olyazavr
    olyazavr committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d95bd0e View commit details
    Browse the repository at this point in the history