-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in rbac api. #124103
Fix typos in rbac api. #124103
Conversation
Signed-off-by: zhanluxianshen <irelandabby883@gmail.com>
The committers listed above are authorized under a signed CLA. |
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Mar 28 20:12:24 UTC 2024. |
Welcome @zhanluxianshen! |
Hi @zhanluxianshen. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/triage accepted /assign liggitt This is not really a typo. Need to check if this is backward compatible or introduces any breaking changes. |
/ok-to-test |
we got lucky, this is a repeated field, which is automatically optional in proto... this produced no change in the rbac generated.proto files or the generated pb.go files, so there is no impact to the proto wire compatibility /lgtm |
LGTM label has been added. Git tree hash: e8957d45577da6dccc166af23d4eb6eb4c50ee80
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, zhanluxianshen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
😀,Thanks for review. |
/test pull-kubernetes-integration |
/test pull-kubernetes-node-e2e-containerd |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fix typos in rbac api.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: