refactor: change dynamicResources struct to DynamicResources

[Subhasish-Behera]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

It refactors the dynamicResources struct to DynamicResources struct.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.30 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.30.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 11 07:45:25 UTC 2024.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @Subhasish-Behera!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Subhasish-Behera. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Subhasish-Behera
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

/remove-sig node
/sig scheduling

Even though DRA is led by sig-node, I think scheduling has the main say here.

[kannon92]

/ok-to-test

You will probably need to explain why this is necessary. Changing to DynamicResources implies that this should be exported for usage elsewhere.

[pohly]

I know what this is for based on prior discussion on Slack, but I agree with @kannon92: this needs to be documented in the commit message and the PR description. PRs must make sense to reviewers who lack additional background.

@Subhasish-Behera: has this been tested with volcano?

I want to be sure that this change is complete and really helps before merging it.

[kannon92]

if the goal would be to use this in order projects should we be letting people import from K8s pkg/scheduler?

I thought that we would want to move this API to staging so people could import versioned apis into their projects.

[pohly]

The plugin depends on APIs that are only available in k/k (pkg/scheduler/framework), therefore it cannot be moved to staging - perhaps it could, but any consumer then would still depend on k/k, which defeats the purpose of moving the plugin to staging.

[kannon92]

Yea I took a look at scheduler plugins and I see it’s imported there so feel free to disregard this comment.

[Subhasish-Behera]

@pohly I tried importing this branch to use in Volcano for testing but there were some version mismatch errors. I will try to figure that out quickly (I am assuming that is the way to test before getting merged).
But for reference the DRA plugin will be accessed in a similar manner as nodeAffinity and its filter function in one of volcano's own plugin (Link: https://github.com/volcano-sh/volcano/blob/master/pkg/scheduler/plugins/predicates/predicates.go#L308).

[pohly]

I am assuming that is the way to test before getting merged

Yes.

[Subhasish-Behera]

Apart from that, a check is failing due to an end-to-end test failing. Is it because more refactoring is necessary.

[Monokaix]

Apart from that, a check is failing due to an end-to-end test failing. Is it because more refactoring is necessary.

Try to retest it: )

[Monokaix]

/retest

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.