CRI: Add field to support CPU affinity on Windows

[kiashok]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds CRI field 'affinity_cpus' to WindowsContainerResources struct to support CPU affinity on windows.
This field will be used by Windows CPU manager to set the logical processors to affinitize for a particular container down to containerd/hcsshim.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

CRI: Add field to support CPU affinity on Windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node
/sig windows

/cc @jsturtevant @marosset @aravindhp

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.30 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.30.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 11 19:48:19 UTC 2024.

[ffromani]

/cc

[swatisehgal]

/retest

[aravindhp]

@kiashok thank you for the PR.

This field will be used by Windows CPU manager to set the logical processors to affinitize for a particular container down to containerd/hcsshim.

Is any follow up work required for this? It will help if you can link to any docs about the Windows CPU manager.

[aravindhp]

/triage accepted
/priority important-soon

[jsturtevant]

xref: #125262

[ffromani]

just curious why close? is there a better direction for this work?

[kiashok]

just curious why close? is there a better direction for this work?

@ffromani all I wanted to do is push new changes and when I did so, it closed the PR automatically. Not sure why! Would ideally want to reopen this PR

[ffromani]

/reopen

[k8s-ci-robot]

@ffromani: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kiashok
Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/src/k8s.io/cri-api/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

just curious why close? is there a better direction for this work?

@ffromani all I wanted to do is push new changes and when I did so, it closed the PR automatically. Not sure why! Would ideally want to reopen this PR

If you delete the remote branch (git push -d origin BRANCHNAME) it will automatically close the PR. Not sure this is what happened for you but I managed to shot myself in the foot many times with this.

[kiashok]

just curious why close? is there a better direction for this work?

@ffromani all I wanted to do is push new changes and when I did so, it closed the PR automatically. Not sure why! Would ideally want to reopen this PR

If you delete the remote branch (git push -d origin BRANCHNAME) it will automatically close the PR. Not sure this is what happened for you but I managed to shot myself in the foot many times with this.

No, I did not delete the remote branch at all. Did a rebase, made new changes and pushed the branch.

[kiashok]

/reopen

Thanks for reopening this PR!