New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #123322: add log verbosity to endpoint topology hint #124355
Automated cherry pick of #123322: add log verbosity to endpoint topology hint #124355
Conversation
We enabled topology hint on one of our services and this log line was emitted ~92 million times in one day from one cluster tripping our log quota for that cluster, as it is the log line cannot be disabled via the `-v` flag because it does not specify verbosity. I think more log locations need to set verbosity at which they are logged, but this one is currently hurting the most.
Hi @liangyuanpeng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @aojea |
/assign @thockin |
/lgtm The change is only on logging and solves a performance scalability problem
|
LGTM label has been added. Git tree hash: 6f26f4916e87f205f5e195b53a37c291dd372d00
|
/ok-to-test |
/kind bug It needs a release note or just set it to NONE |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
@kubernetes/release-managers |
/retest |
ping @kubernetes/release-managers this is a problem on large clusters, do you mind prioritizing it? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, liangyuanpeng, saschagrunert, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
releated #124341
this is not cve and not a bug. Just change some log to v2 and can reduce the pressure on cluster administrators, so it's a relatively safe thing.
Cherry pick of #123322 on release-1.28.
#123322: add log verbosity to endpoint topology hint
For details on the cherry pick process, see the cherry pick requests page.