-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump base images for agnhost #124382
Bump base images for agnhost #124382
Conversation
|
Welcome @riendeau! |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @riendeau. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Please sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 0e9a3cf9fd2d49c801cffa84354e2f338df87976
|
/retest
Ack. I will be signing as a corporate contributor and am making sure I've got all the right boxes ticked on my side; apologies for the delay. |
/easycla |
CLA signed and PR rebased. |
linux/arm64=arm64v8/alpine:3.12 | ||
linux/ppc64le=ppc64le/alpine:3.12 | ||
linux/s390x=s390x/alpine:3.12 | ||
linux/amd64=alpine:3.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not we go to a more recent version https://alpinelinux.org/releases/ , this will be EOL in 2024-05-23 , I would not use 3.19 as it is still very recent but 3.18 seems to be out for a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.16 is the oldest version which is still receiving security fixes; I chose to move there in the interest of making the minimal changes necessary to satisfy that requirement, rather than jumping to more recent releases and potentially increasing the risk of unintended side-effects.
If the preference would be to move to 3.18, however, I'd be happy to update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your logic sounds better than mine :)
/lgtm |
LGTM label has been added. Git tree hash: 8fc729c6780ba572d23ae2de70ddbfdd9bb18570
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, mkumatag, riendeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
/kind bug
What this PR does / why we need it:
Bumps the alpine version used by the agnhost image from 3.12 to 3.16 to get to a version that is still supported and receiving security fixes.
Which issue(s) this PR fixes:
Fixes #124377
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: