Automated cherry pick of #124289: e2e node: fix -v support #124415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 43539c8 (first released in v1.30.0-alpha.2), the test/e2e/framework manages -v and -vmodule and uses them for a logger which writes to the Ginkgo output stream. This did not work for test/e2e_node, because: - logs.AddFlags(pflag.CommandLine) registers its own -v and -vmodule flags - pflag.CommandLine.AddGoFlagSet(flag.CommandLine) skips the corresponding flags in the flag.CommandLine - pflag.Parse() initializes the settings in the "logs" package even though those are not used at runtime The solution is to not use the "logs" package.
Even if the textlogger which writes to Ginkgo is installed as the logger in klog, klog still does some verbosity checks itself (for example, klog.V().Enabled). Therefore the framework has to keep the verbosity settings in the textlogger and in klog consistent. This is done by wrapping the Set call instead of replacing it.
k8s-ci-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
area/e2e-test-framework
k8s-ci-robot
added
area/test
approved
|
/assign @SergeyKanzhelev |
|
failures are from k8s infra /retest /approve Change is small and test-only. And will make things easier for 1.30. Suitable for cherry pick for sure. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 591af649abc0abc6128acbd7e55b3eff23766b22
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc kubernetes/release-managers |
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/kind bug |
k8s-ci-robot
added
kind/bug
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
should have done all PR metadata in a single comment. Sorry for the spam |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Verolop
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #124289 on release-1.30.
#124289: e2e node: fix -v support
For details on the cherry pick process, see the cherry pick requests page.