Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove feature-gate ConsistentHTTPGetHandlers #124463

Merged
merged 1 commit into from
May 1, 2024
Merged

remove feature-gate ConsistentHTTPGetHandlers #124463

merged 1 commit into from
May 1, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Apr 23, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

ConsistentHTTPGetHandlers: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.31

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature gate `ConsistentHTTPGetHandlers`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2024
@carlory
Copy link
Member Author

carlory commented Apr 23, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 23, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Apr 23, 2024

/triage accepted
/priority important-longterm
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2024
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 79619ef5a9894c7445bae7cdd5d23c4f84b631ce

@sftim
Copy link
Contributor

sftim commented Apr 23, 2024

Changelog suggestion

Removed generally available feature gate `ConsistentHTTPGetHandlers`.

@carlory
Copy link
Member Author

carlory commented Apr 24, 2024

/assign @luxas

@dims
Copy link
Member

dims commented May 1, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit e342ab0 into kubernetes:master May 1, 2024
15 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done May 1, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 1, 2024
@carlory carlory mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@luxas luxas

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carlory @bart0sh @k8s-ci-robot @sftim @dims @luxas