Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FeatureSupportChecker for etcd storage #124483

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add FeatureSupportChecker for etcd storage #124483

merged 1 commit into from
Apr 29, 2024

Conversation

ah8ad3
Copy link
Member

@ah8ad3 ah8ad3 commented Apr 23, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new mechanism to check if Etcd supports a feature or not, with implementation of checking support of RequestWatchProgress. It was previously inside #123264.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

This idea came from implementing of #123192 issue that was part of kubernetes/enhancements#2340 and we decide to separate it from the main PR.

/cc @wojtek-t @serathius

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ah8ad3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2024
@wojtek-t wojtek-t self-assigned this Apr 24, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented Apr 24, 2024

Thanks for comments @serathius. I fix them in last commit PTAL.

@ah8ad3
Copy link
Member Author

ah8ad3 commented Apr 26, 2024 •
edited

Rewrite the tests to address comments.
Just two points about tests:

  1. Malformed etcd version like 3.5.---a will disable the feature.
  2. Error when calling Status function (to get version) will not change the result of supporting.

PTAL.

@serathius
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d770d087c829290a2f28adc16c2931adb86eae94

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented Apr 26, 2024 •
edited

Usually my IDE would tell me about spelling but i'm not sure what happened with it, updated.

@ah8ad3
Copy link
Member Author

ah8ad3 commented Apr 29, 2024

Comments addressed in last commit. PTAL @serathius @wojtek-t .

@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 86c8af1fea368ea70e8519c5d5a67a9840c5333b

@wojtek-t
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ah8ad3, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented Apr 29, 2024

Thanks, happy to be a part of this.

@k8s-ci-robot k8s-ci-robot merged commit 4946c1f into kubernetes:master Apr 29, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 29, 2024
@ah8ad3 ah8ad3 deleted the etcd_feature_support branch April 29, 2024 10:22
@cici37
Copy link
Contributor

cici37 commented Apr 30, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@serathius serathius

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ah8ad3 @k8s-ci-robot @serathius @cici37 @wojtek-t