-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the version order of 'discovery.k8s.io' #124602
fix the version order of 'discovery.k8s.io' #124602
Conversation
/sig api-machinery |
b55daef
to
cdda96f
Compare
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
cdda96f
to
498bebe
Compare
/cc @alexzielenski If you would have time to review this one? Thank you! |
/remove-kind bug This isn't a bug, we just never updated the storage version, which normally happens one release after adding the new version |
@liggitt: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind cleanup |
/lgtm |
LGTM label has been added. Git tree hash: 859ea94270d4a4e36efde560f2e29a2ec7f7473e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Iceber, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixed the version order of discovery.k8s.io resource, wrong order could cause wrong prioritized version when using
pkg/apis/disovery/install.Install
.This will also result in v1beta1 still being used as the storage version for endpointslice
$ /etcdctl --endpoints="https://127.0.0.1:2379" --cert=/etc/kubernetes/pki/apiserver-etcd-client.crt --key=/etc/kubernetes/pki/apiserver-etcd-client.key --cacert=/etc/kubernetes/pki/etcd/ca.crt get --prefix /registry/endpointslices/default/kubernetes /registry/endpointslices/default/kubernetes k8s ) EndpointSlice.io/v1beta1 ...
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: