Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: warn user if etcd version is not supported for RequestWatchProgress feature. #124612

Merged
merged 1 commit into from
May 10, 2024
Merged

Feat: warn user if etcd version is not supported for RequestWatchProgress feature. #124612

merged 1 commit into from
May 10, 2024
+83 −55

Conversation

ah8ad3
Copy link
Member

@ah8ad3 ah8ad3 commented Apr 29, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Part of kubernetes/enhancements#2340

Which issue(s) this PR fixes:

Fixes #123192

Special notes for your reviewer:

Warns user on storage initializer and disable the usage of RequestWatchProgress when the etcd version is not supported.

Does this PR introduce a user-facing change?

Checking etcd version to warn about deprecated etcd versions if `ConsistentListFromCache` is enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Old PR: #123264

/cc @wojtek-t @serathius

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 29, 2024
@wojtek-t wojtek-t self-assigned this Apr 30, 2024
@wojtek-t wojtek-t mentioned this pull request Apr 30, 2024
Closed
@cici37
Copy link
Contributor

cici37 commented Apr 30, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
@ah8ad3
Copy link
Member Author

ah8ad3 commented May 1, 2024 •
edited

The Supports got removed from storage interface, and checkClient private function added to feature_support_checker to run goroutine per endpoint and return error. Also i kept the commit so i can compare it to the previous one, once it's good enough i will squash it.

PTAL @serathius @wojtek-t .

@ah8ad3
Copy link
Member Author

ah8ad3 commented May 7, 2024 •
edited

Updated the code and ask some questions in comments. PTAL @serathius @wojtek-t
Now the CheckClient will return instantly and runs a goroutine with ExponentialBackoff that checks for support with timeout of 10 minutes.

@serathius
Copy link
Contributor

Thanks for investigating the backoff.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e82a619e73662e9f5633b1266e09e62975eeb6d

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
wojtek-t
wojtek-t reviewed May 10, 2024
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments PTAL

staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Show resolved Hide resolved
@ah8ad3
Copy link
Member Author

ah8ad3 commented May 10, 2024

I don't understand this.

Let's unblock one of the features and not block both..

Comments addressed, PTAL @wojtek-t @serathius @p0lyn0mial

wojtek-t
wojtek-t reviewed May 10, 2024
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few more minor comments from me.

staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go Show resolved Hide resolved
@ah8ad3
Copy link
Member Author

ah8ad3 commented May 10, 2024

Comments addressed, PTAL @wojtek-t @serathius @p0lyn0mial

@wojtek-t
Copy link
Member

This looks good to me, but I will Marek tag it.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ah8ad3, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@serathius
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a2004ddfdf40089ccc1badbdfc2a1c9902df2c3

@k8s-ci-robot k8s-ci-robot merged commit d8ed461 into kubernetes:master May 10, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 10, 2024
@ah8ad3 ah8ad3 deleted the add-clc-warning branch May 10, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

Assignees

@serathius serathius

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

Implement checking etcd version to warn about deprecated etcd versions
6 participants
@ah8ad3 @cici37 @serathius @k8s-ci-robot @wojtek-t @p0lyn0mial