-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add label(s) modified
message for kubectl label command
#124647
base: master
Are you sure you want to change the base?
feat: add label(s) modified
message for kubectl label command
#124647
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ba50a36
to
b6832b0
Compare
label(s) modified
message for kubectl label command
b6832b0
to
70aff12
Compare
/cc @brianpursley |
Thanks for the PR. I think it would be nice if we change from
to just simply
but wait for other reviewer for this. |
Thanks for the review, and I see your point. However, it would be cleaner from a UX perspective if the user knew what happened exactly. The current setup in the PR allows the user to differentiate between adding labels, removing labels, and adding and removing labels by the same operation. Therefore, I see that printing |
Signed-off-by: TessaIO <ahmedgrati1999@gmail.com>
70aff12
to
d73951c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TessaIO The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR aims to modify the
kubectl label
command when we add and remove labels at the same time. In fact, the old behavior was based on the length of labels being added/removed. Now, if we remove and add labels at the same operation we just outputlabel(s) modified
Which issue(s) this PR fixes:
Fixes #1312
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: