Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demonstrate VAP restricting action per-node #124711

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

demonstrate VAP restricting action per-node #124711

wants to merge 1 commit into from
+338 −0

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 6, 2024

Add test showing how validating admission policy and SA token node claims can be used to enforce per-node mutation.

/sig auth
/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 6, 2024
@deads2k deads2k changed the title demonstrate VAP restricting action per-node [wip] demonstrate VAP restricting action per-node May 6, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from enj and liggitt May 6, 2024 21:07
@deads2k deads2k force-pushed the vap-per-node branch 2 times, most recently from 84d45b8 to a8d1284 Compare May 8, 2024 14:22
@enj enj mentioned this pull request May 8, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 28, 2024
@deads2k deads2k force-pushed the vap-per-node branch 4 times, most recently from 6bb9ced to be108fa Compare May 31, 2024 13:50
@deads2k deads2k changed the title [wip] demonstrate VAP restricting action per-node demonstrate VAP restricting action per-node May 31, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd f454764 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-unit f454764 link true /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented May 31, 2024

/triage accept
/priority important-soon
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 31, 2024
@k8s-ci-robot
Copy link
Contributor

@deads2k: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept
/priority important-soon
/milestone v1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 31, 2024
@deads2k deads2k mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Auth
Status: Needs Triage
[sig-release] Bug Triage
Status: No status
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deads2k @k8s-ci-robot