-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More assertive borrowing by exempt #124736
base: master
Are you sure you want to change the base?
More assertive borrowing by exempt #124736
Conversation
Happy middle ground with what the KEP says? Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @tkashem |
This change makes sense to me, but we need some tests for it... |
/triage accepted |
/retest |
c7b5e2c
to
5ec631a
Compare
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
5ec631a
to
9aa9d3d
Compare
Here is an example of running the new unit test:
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR changes the way that exempt priority levels borrow from non-exempt ones in API Priority and Fairness. Note that the code does not match the KEP on this matter, which is Issue #124125 . This PR shifts the code to a middle position. A companion PR (kubernetes/enhancements#4623) shifts the KEP to the same place.
Which issue(s) this PR fixes:
This is the code part of one possible way to addressing #124125 .
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: