-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.30: Clean up PersistentVolumeLabel admission plugin #124794
1.30: Clean up PersistentVolumeLabel admission plugin #124794
Conversation
Azure and vSphere cloud providers were removed in v1.30. Remove their usage from PersistentVolumeLabel admission plugin, otherwise the admission plugin refuses creation of in-tree AzureDisk or vSphere volume.
/sig storage |
@jsafrane: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig cloud-provider |
/approve |
LGTM label has been added. Git tree hash: 66df28ea8ccee50e84064f69ac8821ce10ea95c6
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The admission plugin is not on by default… isn't the more correct adjustment for azure / vsphere clusters to not enable it in 1.30+? what happens if it is enabled in those clusters with this PR removing the azure / vsphere implementations? Edit: I guess we hit the "Unrecognized volume, do not add any labels" case… I guess either deleting the code like this or the cluster stopping using the admission plugin seems ok |
This is a manual fix of #124504 in release-1.30 branch.
#124504 was fixed in master by removing the admission plugin. IMO it's not a good idea to remove the plugin in already released version, so cleaning up the admission not to use the removed cloud provider.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Azure and vSphere cloud providers were removed in v1.30. Remove their usage from
PersistentVolumeLabel
admission plugin, otherwise the admission plugin refuses creation of in-tree AzureDisk or vSphere volume.Related to #124504, just fixing it in 1.30.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: