Make replica controllers return current state. #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,6 +105,7 @@ func (rs *REST) List(selector labels.Selector) (runtime.Object, error) { | |||
| filtered := []api.ReplicationController{} | |||
| for _, controller := range controllers.Items { | |||
| if selector.Matches(labels.Set(controller.Labels)) { | |||
| rs.fillCurrentState(&controller) | |||
There was a problem hiding this comment.
Yep, do we care? This is all pretty local.
There was a problem hiding this comment.
I don't think we care at the moment, but stuff like this will keep us from scaling out of the 100's of pods and rep. controllers.
|
I'd prefer to get this in as-is. We can always improve the implementation later to make it watch-able and improve performance. Your call, though, about how perfect you want this to be before we submit. |
brendandburns
force-pushed
the
replicas
branch
from
4734b28
to
e7625c8
Compare
|
Added the fillCurrentState behavior to the Watch function as well. (clearly changes don't actually trigger a watch event, so it's imperfect) |
|
LGTM. I'll let this go until we have @erictune's indexing thingy available. |
lavalamp
added a commit
that referenced
this pull request
Sep 9, 2014
Make replica controllers return current state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.