-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require prerelease lifecycle tags on GA types #124898
Require prerelease lifecycle tags on GA types #124898
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Lgtm. Verify is still red. Needs an API approver for finally tagging. |
7598816
to
08a8e3e
Compare
cd "${KUBE_ROOT}" | ||
for DOCGLOB in "${DIRGLOBS[@]}"; do | ||
if git --no-pager grep -L '// +k8s:prerelease-lifecycle-gen=true' -- "$DOCGLOB" ":!*api*/*alpha*/doc.go"; then | ||
echo "!!! Some non-alpha packages doc.go do not include prerelease-lifecycle tags." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open another PR based on this one that shows this catching a failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts did you confirm the bazillion listed versions were accurate? The mechanics here look correct and if the versions are correct I'm ready to approve once there's a proof PR showing the verify works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I few of these version numbers didn't match what I found when bisecting with:
git checkout release-<major.minor>
find . -name "types.go" | grep -v "Godeps" | xargs grep struct | grep <Kind>
@@ -23,6 +23,7 @@ import ( | |||
|
|||
// +genclient | |||
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
// +k8s:prerelease-lifecycle-gen:introduced=1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Event should be 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because the PR adding this struct was in 1.19 milestone
Estimated based upon the milestone of the commit that added the original struct header. If the commit wasn't in a milestone used the deprecation of the prior beta api. If that wasn't available inferred the next available release from the date the commit was merged.
08a8e3e
to
0095f60
Compare
/lgtm |
LGTM label has been added. Git tree hash: 65215ce1b0318a00232f3bea124dbf997b04441f
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
#122891 requires that all known API types have availability information stored for the k8s versions it was introduced to be able to choose a storage version compatible with an emulated k8s version. We have this information currently for beta types, but not GA. This PR enforces the requirement that GA types have the annotation, and modifies the code generator to not output deprecated/removed implementations for such GA types.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: