Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_node: skip swap tests on cgroupv1 #125027

Merged
merged 1 commit into from
May 22, 2024
Merged

e2e_node: skip swap tests on cgroupv1 #125027

merged 1 commit into from
May 22, 2024

Conversation

haircommander
Copy link
Contributor

@haircommander haircommander commented May 21, 2024 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

fixes #125026

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@haircommander
e2e_node: skip swap tests on cgroupv1
ba80f25 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 21, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 21, 2024
@iholder101
Copy link
Contributor

/lgtm
Thank you @haircommander!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 36dbbb588df456c18cc1fe9a2e875ea0b2e3916f

@bart0sh
Copy link
Contributor

bart0sh commented May 22, 2024

/retest

@bart0sh
Copy link
Contributor

bart0sh commented May 22, 2024

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 22, 2024
@bart0sh bart0sh moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board May 22, 2024
@bart0sh
Copy link
Contributor

bart0sh commented May 22, 2024

/cc @SergeyKanzhelev @mrunalp @dims
PTAL, this will make Sig-Node test grid much greener

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@haircommander
Copy link
Contributor Author

@iholder101 there are other test lanes failing because they're running serial on cgroupv1. I think until we go through the process of deprecating v1 we should skip these.

@haircommander
Copy link
Contributor Author

@SergeyKanzhelev can you PTAL

@dims
Copy link
Member

dims commented May 22, 2024

/approve
/lgtm

thanks @haircommander

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b16105f58ac287e13d507986b2f529e84f7c4eea

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5cdab88 into kubernetes:master May 22, 2024
15 checks passed
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done May 22, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 22, 2024
@pacoxu pacoxu mentioned this pull request May 23, 2024
Closed
@iholder101
Copy link
Contributor

@iholder101 there are other test lanes failing because they're running serial on cgroupv1. I think until we go through the process of deprecating v1 we should skip these.

Makes sense. Thank you @haircommander!

@haircommander haircommander mentioned this pull request May 31, 2024
Merged
@bitoku bitoku mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@rphillips rphillips Awaiting requested review from rphillips

@dims dims Awaiting requested review from dims

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@iholder101 iholder101 Awaiting requested review from iholder101

Assignees

@dims dims

@iholder101 iholder101

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

[Failing Test] ci-crio-cgroupv1-node-e2e-conformance (Swap Tests)
5 participants
@haircommander @iholder101 @k8s-ci-robot @bart0sh @dims