Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex #125039

Merged
merged 2 commits into from
May 23, 2024
Merged

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex #125039

merged 2 commits into from
May 23, 2024
+55 −1

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented May 22, 2024 •
edited by liggitt
Loading

Cherry pick of #124933 on release-1.30.

#124933: base on allNodes when calculating nextStartNodeIndex

For details on the cherry pick process, see the cherry pick requests page.

kube-scheduler: fixes a 1.30 regression that can lead to a scheduler crash when processing pods with affinity that doesn't match a real/valid node

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone May 22, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 22, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 22, 2024
@AxeZhan AxeZhan mentioned this pull request May 22, 2024
Closed
@AxeZhan
Copy link
Member Author

AxeZhan commented May 22, 2024

/cc @alculquicondor @Huang-Wei

@AxeZhan
Copy link
Member Author

AxeZhan commented May 22, 2024

/kind bug
/kind regression

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 22, 2024
@alculquicondor
Copy link
Member

/lgtm
/approve
/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team May 22, 2024 14:09
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4605050c959641e961c40fdac29b20bea73e484

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@alculquicondor
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 22, 2024
xmudrii
xmudrii approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, AxeZhan, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be4afb9 into kubernetes:release-1.30 May 23, 2024
17 checks passed
@sara-hann
Copy link

@AxeZhan @xmudrii Thanks for fixing this so fast. How do I pull this new code? I see that your PR was merged, but I don't see a new release to pull? looking for the 1.30

@AxeZhan
Copy link
Member Author

AxeZhan commented May 28, 2024

@sara-hann For souce code you can directly pull release-1.30 branch.
For a new release, maybe need to wait for some time. https://kubernetes.io/releases/patch-releases/

@sara-hann
Copy link

@AxeZhan sorry if this is a dumb question, but, I'm looking at the release-1.30, and it seems the last change was in April. will your code not be available until a 1.30.2 release comes out? I'm trying to upgrade my kubeadm on RedHat to pull in your latest fix, but the latest available code to upgrade to seems to be GitVersion:"v1.30.1", GitCommit:"6911225c3f747e1cd9d109c305436d08b668f086" which has a build date of "2024-05-14".

@alculquicondor
Copy link
Member

K8s patch releases happen around once a month. This fix will be included in v1.30.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@damemi damemi Awaiting requested review from damemi

@denkensk denkensk Awaiting requested review from denkensk

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@alculquicondor alculquicondor

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AxeZhan @k8s-ci-robot @alculquicondor @sara-hann @xmudrii