Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Increase preStop hook delay to deflake the test #125090

Merged
merged 1 commit into from
May 23, 2024
Merged

e2e: Increase preStop hook delay to deflake the test #125090

merged 1 commit into from
May 23, 2024

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented May 23, 2024 •
edited

What type of PR is this?

/kind flake
/kind failing-test

What this PR does / why we need it:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/125073/pull-kubernetes-node-e2e-containerd/1793373424723169280

50) 2024-05-22 20:22:37.013 +0000 UTC Readiness-regular-1 Exiting
51) 2024-05-22 20:22:37.065 +0000 UTC PreStop-regular-1 Starting
52) 2024-05-22 20:22:37.074 +0000 UTC PreStop-regular-1 Started
53) 2024-05-22 20:22:37.081 +0000 UTC PreStop-regular-1 Delaying
54) 2024-05-22 20:22:38.065 +0000 UTC Readiness-regular-1 Starting
55) 2024-05-22 20:22:38.12 +0000 UTC PreStop-regular-1 Exiting
56) 2024-05-22 20:22:38.132 +0000 UTC Readiness-regular-1 Started
57) 2024-05-22 20:22:38.161 +0000 UTC Readiness-regular-1 Delaying
58) 2024-05-22 20:22:38.18 +0000 UTC Readiness-regular-1 Exiting
59) 2024-05-22 20:22:39.029 +0000 UTC Readiness-regular-1 Starting
60) 2024-05-22 20:22:39.067 +0000 UTC Readiness-regular-1 Started
61) 2024-05-22 20:22:39.095 +0000 UTC Readiness-regular-1 Delaying
62) 2024-05-22 20:22:39.11 +0000 UTC Readiness-regular-1 Exiting

Currently, the kubelet sometimes does not have enough time to execute the readiness probe during the prestop hook.

This PR delays the preStop hook to allow sufficient time for the readiness probe to be executed.

Which issue(s) this PR fixes:

Fixes #
xref: #124791

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@gjkim42
e2e: Increase preStop hook delay to deflake the test
65b9e56 
This delays the preStop hook to allow sufficient time for the readiness
probe to be executed.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 23, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 23, 2024
@gjkim42
Copy link
Member Author

gjkim42 commented May 23, 2024

/cc @matthyx
/assign @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot requested a review from matthyx May 23, 2024 12:48
matthyx
matthyx approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 46ea0459d2eade6a46eeb9f7c5e18443e850e98a

SergeyKanzhelev
SergeyKanzhelev approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, matthyx, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 028b457 into kubernetes:master May 23, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@gjkim42 gjkim42 deleted the deflake-container-lifecycle-e2e-test branch May 24, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@matthyx matthyx matthyx approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@SergeyKanzhelev SergeyKanzhelev

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gjkim42 @k8s-ci-robot @SergeyKanzhelev @matthyx